JP-3268: Fix pixel_replace step status error

[hbushouse]

Resolves JP-3268

This PR fixes the pixel_replace step code so that it properly updates the step status keyword on completion. Previously a data model object was being updated that was not the model returned from the step, so the update was lost.

Checklist for maintainers

• added entry in CHANGES.rst within the relevant release section
• updated or added relevant tests
• updated relevant documentation
• added relevant milestone
• added relevant label(s)
• ran regression tests, post a link to the Jenkins job below.
  How to run regression tests on a PR
• Make sure the JIRA ticket is resolved properly

[codecov]

Codecov Report

Patch and project coverage have no change.

Comparison is base (4ea2860) 76.61% compared to head (7d00e57) 76.61%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #7619   +/-   ##
=======================================
  Coverage   76.61%   76.61%           
=======================================
  Files         456      456           
  Lines       36819    36819           
=======================================
  Hits        28209    28209           
  Misses       8610     8610           

Flag	Coverage Δ		*Carryforward flag
nightly	77.43% <ø> (ø)		Carriedforward from 4ea2860

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files	Coverage Δ
jwst/pixel_replace/pixel_replace_step.py	26.66% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[hbushouse]

regtest started at https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/761

[nden]

lgtm

[tapastro]

🙈

[hbushouse]

regtest run intentionally used CRDS_TEST, which contains an updated pars-spec2pipeline ref file for MIRI LRS that turns on the pixel_replace step. The LRS tests show that the S_PXREPL keyword is now present and populated. All other failures are due to the differences in ref files in CRDS_TEST vs. CRDS_OPS (which is what the truth files are based on). So this looks good.