remove mistune pin and increase minimum sphinx-asdf version #7696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sphinx-asdf 0.1.2 added the mistune pin that this commit removes from jwst (so 0.1.2 is equivalent to 0.1.1 with the pin) keeping the pin does not allow jwst to use sphinx-asdf 0.2.0 (which requires mistune >= 3.0.0)
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #7696 +/- ##
=======================================
Coverage 76.56% 76.56%
=======================================
Files 456 456
Lines 36877 36877
=======================================
Hits 28234 28234
Misses 8643 8643
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the mistune dependency (and pin).
This pin appears to have been added to deal with sphinx-asdf 0.1.1 not pinning mistune and a new version of mistune being released which broke the docs.
#6490
The pin was also added to sphinx-asdf 0.1.2 so bumping the minimum version of sphinx-asdf 0.1.2 means the mistune pin is no longer needed in jwst. This PR increases the minimum version of sphinx-asdf to 0.1.2
Removing this pin allows sphinx-asdf 0.2.0 to be installed which removes many of the deprecated call warnings when building the docs.
As can be seen by comparing this docs build log for this PR
https://readthedocs.org/projects/jwst-pipeline/builds/21213123/
to a build log for a PR where sphinx-asdf<0.2.0 is used:
https://readthedocs.org/projects/jwst-pipeline/builds/21211054/
Checklist for maintainers
CHANGES.rstwithin the relevant release sectionHow to run regression tests on a PR