-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refpix bug fix #7731
Refpix bug fix #7731
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #7731 +/- ##
==========================================
- Coverage 76.60% 76.41% -0.20%
==========================================
Files 456 456
Lines 36947 36950 +3
==========================================
- Hits 28303 28235 -68
- Misses 8644 8715 +71
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code updates look OK, but getting CI failures, because the "test_rm_intermittent_badpix.py" unit test module needs to be updated to include the new argument in the function call. Also need an update to docs for the new step argument.
Mike reported 3 datasets that caused an error for this condition. I've copied the uncal files to /grp/jwst/ssb/chartreuse/dms_bugs/jp-3157/ for testing purposes (to see if this PR avoids the error). |
Added documentation, fixed test, and tested with data from central store. All good from my end. |
Regression test run started at https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/786 |
Regression test results show minor differences in pixel values starting with and downstream from the refpix step, which I'm assuming are expected differences due to this change. No errors of any kind. |
This PR resolves a potential crash due to an empty list. Also added a factor to mitigate the overcorrection due to suspicious intermittently bad reference pixels.
Checklist for maintainers
CHANGES.rst
within the relevant release sectionHow to run regression tests on a PR