Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split requirements-dev.txt into first and third party dev dependencies #7849

Merged

Conversation

zacharyburnett
Copy link
Collaborator

@zacharyburnett zacharyburnett commented Aug 24, 2023

This PR separates requirements-dev.txt into

  • requirements-dev-thirdparty.txt - third party dependencies (numpy, scipy, etc)
  • requirements-dev-st.txt - STScI projects directly related to JWST (stdatamodels, stcal, stpipe, etc.)

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@zacharyburnett zacharyburnett self-assigned this Aug 24, 2023
@github-actions github-actions bot added testing installation regression_testing automation Continuous Integration (CI) and testing automation tools labels Aug 24, 2023
@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Patch has no changes to coverable lines.

❗ Current head 0815aa2 differs from pull request most recent head 2e83a2b. Consider uploading reports for the commit 2e83a2b to get more accurate results

📢 Thoughts on this report? Let us know!.

@zacharyburnett zacharyburnett force-pushed the deps/separate_dev branch 2 times, most recently from efa5724 to b58c2a6 Compare August 25, 2023 15:59
@zacharyburnett zacharyburnett marked this pull request as ready for review August 28, 2023 13:18
@zacharyburnett zacharyburnett requested a review from a team as a code owner August 28, 2023 13:18
@zacharyburnett zacharyburnett changed the title separate dev requirements into two files separate requirements-dev.txt into first and third party dev dependencies Aug 29, 2023
@zacharyburnett zacharyburnett changed the title separate requirements-dev.txt into first and third party dev dependencies split requirements-dev.txt into first and third party dev dependencies Aug 29, 2023
@nden
Copy link
Collaborator

nden commented Sep 19, 2023

@zacharyburnett Since this change the Jenkins file could you run a regression test?

@zacharyburnett
Copy link
Collaborator Author

zacharyburnett commented Sep 19, 2023

Copy link
Collaborator

@mairanteodoro mairanteodoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@zacharyburnett zacharyburnett merged commit cc2c119 into spacetelescope:master Oct 1, 2023
@zacharyburnett zacharyburnett deleted the deps/separate_dev branch October 1, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants