-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
split requirements-dev.txt
into first and third party dev dependencies
#7849
split requirements-dev.txt
into first and third party dev dependencies
#7849
Conversation
Codecov ReportPatch has no changes to coverable lines.
📢 Thoughts on this report? Let us know!. |
efa5724
to
b58c2a6
Compare
b58c2a6
to
d42c8ad
Compare
d42c8ad
to
2e05e3a
Compare
requirements-dev.txt
into first and third party dev dependencies
requirements-dev.txt
into first and third party dev dependenciesrequirements-dev.txt
into first and third party dev dependencies
2e05e3a
to
3ec7055
Compare
3ec7055
to
3c04318
Compare
@zacharyburnett Since this change the Jenkins file could you run a regression test? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
This PR separates
requirements-dev.txt
intorequirements-dev-thirdparty.txt
- third party dependencies (numpy
,scipy
, etc)requirements-dev-st.txt
- STScI projects directly related to JWST (stdatamodels
,stcal
,stpipe
, etc.)Checklist for maintainers
added entry inCHANGES.rst
within the relevant release sectionupdated or added relevant testsupdated relevant documentationadded relevant milestoneHow to run regression tests on a PR
Make sure the JIRA ticket is resolved properly