-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RampFitStep - accept integer values for maximum_cores
#8123
Conversation
0ab292b
to
03044f1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8123 +/- ##
=======================================
Coverage 75.24% 75.24%
=======================================
Files 470 470
Lines 38420 38420
=======================================
Hits 28908 28908
Misses 9512 9512
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@mwregan2 What are your thoughts on this suggested update? If it's OK for ramp_fit, we should probably make the same change to jump too. |
@hbushouse The same change has been done to jump by #7871. |
I am confused with this. We seem to have lost the change that I put in for ramp fit at the same time I did it for jump. |
I believe your previous changes were only in STCAL: spacetelescope/stcal#183 |
Well, I did make JWST changes but they seem to have been lost. I probably was at fault. |
Given that this change was intended to be implemented before (but apparently got lost) and appears to be exactly the same updates made to the jump step to enable the use integer values for the number of cores, I think this all seems very reasonable and we should adopt it. I've started a regression test run against this PR branch at https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1113 to make sure it's all working OK. |
Regression test differences are all unrelated (related to MIRI emicorr). |
Move #8123 entry in change log to the proper (unreleased) section.
This PR allows
maximum_cores
ofRampFitStep
to accept integer values for the number of cores to be used in multiprocessing. Documentation updates follow the changes in #7871.Checklist for maintainers
CHANGES.rst
within the relevant release sectionHow to run regression tests on a PR