Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RampFitStep - accept integer values for maximum_cores #8123

Merged
merged 3 commits into from
Dec 21, 2023

Conversation

izkgao
Copy link
Contributor

@izkgao izkgao commented Dec 12, 2023

This PR allows maximum_cores of RampFitStep to accept integer values for the number of cores to be used in multiprocessing. Documentation updates follow the changes in #7871.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@izkgao izkgao marked this pull request as ready for review December 12, 2023 09:26
@izkgao izkgao requested a review from a team as a code owner December 12, 2023 09:26
@izkgao izkgao force-pushed the ramp-fit-max-cores branch from 0ab292b to 03044f1 Compare December 12, 2023 13:47
Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1e8b366) 75.24% compared to head (9744dd1) 75.24%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8123   +/-   ##
=======================================
  Coverage   75.24%   75.24%           
=======================================
  Files         470      470           
  Lines       38420    38420           
=======================================
  Hits        28908    28908           
  Misses       9512     9512           
Flag Coverage Δ *Carryforward flag
nightly 77.37% <ø> (ø) Carriedforward from 1e8b366

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hbushouse
Copy link
Collaborator

@mwregan2 What are your thoughts on this suggested update? If it's OK for ramp_fit, we should probably make the same change to jump too.

@izkgao
Copy link
Contributor Author

izkgao commented Dec 15, 2023

@hbushouse The same change has been done to jump by #7871.

@mwregan2
Copy link
Contributor

@mwregan2 What are your thoughts on this suggested update? If it's OK for ramp_fit, we should probably make the same change to jump too.

I am confused with this. We seem to have lost the change that I put in for ramp fit at the same time I did it for jump.

@kmacdonald-stsci
Copy link
Contributor

@mwregan2 What are your thoughts on this suggested update? If it's OK for ramp_fit, we should probably make the same change to jump too.

I am confused with this. We seem to have lost the change that I put in for ramp fit at the same time I did it for jump.

I believe your previous changes were only in STCAL: spacetelescope/stcal#183

@mwregan2
Copy link
Contributor

Well, I did make JWST changes but they seem to have been lost. I probably was at fault.

@hbushouse
Copy link
Collaborator

Given that this change was intended to be implemented before (but apparently got lost) and appears to be exactly the same updates made to the jump step to enable the use integer values for the number of cores, I think this all seems very reasonable and we should adopt it. I've started a regression test run against this PR branch at https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1113 to make sure it's all working OK.

@hbushouse
Copy link
Collaborator

Regression test differences are all unrelated (related to MIRI emicorr).

@hbushouse hbushouse merged commit 306d5a1 into spacetelescope:master Dec 21, 2023
29 checks passed
hbushouse added a commit that referenced this pull request Dec 21, 2023
Move #8123 entry in change log to the proper (unreleased) section.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants