JP-3510: Flag bad refpix within integrations separately #8214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melanieclarke
force-pushed
the
bad_refpix_flagging
branch
from
995435a to
d7bd9d5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8214 +/- ##
=======================================
Coverage 75.18% 75.18%
=======================================
Files 470 470
Lines 38542 38546 +4
=======================================
+ Hits 28976 28980 +4
Misses 9566 9566
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Started a regtest run at https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1170 |
|
Regression test run is clean. Just a few usual failures that sporadically pop up in many test runs. |
|
@melanieclarke I'm ready, willing, and able to merge this now. Are you (and/or Eddie) sure you don't want to make more changes yet? |
|
Thanks @hbushouse - I'm pretty sure we're done with this one now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves JP-3510
Closes #8195
Slight modification to the changes in PR #8197, to compile statistics across all groups within each integration individually. This does a better job at catching bad pixels that jump within one integration but not in the others. Bad pixels flagged in one integration are still replaced in all integrations.
Checklist for maintainers
CHANGES.rstwithin the relevant release sectionHow to run regression tests on a PR