Add option to preserve reference pixels after IRS2 processing #8255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8255 +/- ##
==========================================
+ Coverage 75.15% 75.36% +0.20%
==========================================
Files 470 474 +4
Lines 38604 38839 +235
==========================================
+ Hits 29014 29271 +257
+ Misses 9590 9568 -22
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
melanieclarke
force-pushed
the
preserve_refpix
branch
from
44c2811 to
1c8788a
Compare
hbushouse
reviewed
Feb 28, 2024
|
Regression tests started at https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1240 |
|
The regtest results show failures, but they are all due to another change merged into master since this PR was created, so the PR branch is a bit out of date. The failures are all unrelated. |
hbushouse
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves JP-3529
Closes #8254
This PR allows interleaved reference pixels in NIRSpec IRS2 mode to be preserved in the output from the refpix step. This is needed for calibration reductions, to produce new bias reference files, but should not be used for science reductions.
Checklist for maintainers
CHANGES.rstwithin the relevant release sectionHow to run regression tests on a PR