Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3223: Extract_2d 'slit_name' parameter fails for NRS_MSASPEC slits #8272

Merged
merged 5 commits into from
Feb 15, 2024

Conversation

penaguerrero
Copy link
Contributor

@penaguerrero penaguerrero commented Feb 12, 2024

Resolves JP-3223 (again)

Closes #

This PR addresses a crash of extract_2d when user provides slit_name, and value is a string. This change had been done and merged in #8108 , but it accidentally got undone by a later PR. So note that the original fix was NOT included in DMS B10.1 as we'd assumed. It will now be included in B10.2.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

Copy link

codecov bot commented Feb 12, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (d63fb5a) 75.20% compared to head (bcedbd2) 75.20%.

Files Patch % Lines
jwst/extract_2d/nirspec.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8272   +/-   ##
=======================================
  Coverage   75.20%   75.20%           
=======================================
  Files         470      470           
  Lines       38581    38578    -3     
=======================================
  Hits        29013    29013           
+ Misses       9568     9565    -3     
Flag Coverage Δ *Carryforward flag
nightly 77.38% <ø> (ø) Carriedforward from 2f1a34d

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@penaguerrero penaguerrero changed the title WIP: fixing crash with undefined var JP-3223: Extract_2d 'slit_name' parameter fails for NRS_MSASPEC slits Feb 13, 2024
@hbushouse hbushouse added this to the Build 10.2 milestone Feb 13, 2024
Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a regression test run.

CHANGES.rst Outdated Show resolved Hide resolved
@penaguerrero
Copy link
Contributor Author

@penaguerrero
Copy link
Contributor Author

Reg tests succeeded! Only failures are due to unable to retrieve file from Artifactory.

@hbushouse hbushouse merged commit 8f723b7 into spacetelescope:master Feb 15, 2024
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants