-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JP-3223: Extract_2d 'slit_name' parameter fails for NRS_MSASPEC slits #8272
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #8272 +/- ##
=======================================
Coverage 75.20% 75.20%
=======================================
Files 470 470
Lines 38581 38578 -3
=======================================
Hits 29013 29013
+ Misses 9568 9565 -3
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a regression test run.
Co-authored-by: Howard Bushouse <[email protected]>
reg tests running at: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1201/ |
Reg tests succeeded! Only failures are due to unable to retrieve file from Artifactory. |
Resolves JP-3223 (again)
Closes #
This PR addresses a crash of extract_2d when user provides slit_name, and value is a string. This change had been done and merged in #8108 , but it accidentally got undone by a later PR. So note that the original fix was NOT included in DMS B10.1 as we'd assumed. It will now be included in B10.2.
Checklist for maintainers
CHANGES.rst
within the relevant release sectionHow to run regression tests on a PR