Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update load_local_pkg exclude regex with regtest pattern #8350

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Mar 12, 2024

Fixes #8348

test_suffix.py tests that call jwst.stpipe.utilities.find_suffixes are skipped in unit test runs due to importorskip calls in the regtests (like):

pytest.importorskip('pysiaf')

pysiaf is not installed for CI unit test runs and the call to find_suffixes results in an attempt to import every .py file in the jwst directory structure that is not in a test folder (so regtest is included). This results in an attempt to import for example the above referenced file, the importorskip is called and the test (in this case one in test_suffix) is skipped.

This PR updates the regex to also exclude the regtest directory.

As a comparison here is the latest py310-xdist run log on main:
https://github.com/spacetelescope/jwst/actions/runs/8238566482/job/22529809746#step:10:248
showing:

==== 2785 passed, 554 skipped, 4 xfailed, 79 warnings in 854.19s (0:14:14) =====

With this PR the py310-xdist run log:
https://github.com/spacetelescope/jwst/actions/runs/8254717816/job/22579513473?pr=8350
shows 2 tests were unskipped:

==== 2787 passed, 552 skipped, 4 xfailed, 79 warnings in 905.68s (0:15:05) =====

The 2 tests that now run in the unit tests CI are:

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@braingram braingram marked this pull request as ready for review March 12, 2024 20:34
@braingram braingram requested a review from a team as a code owner March 12, 2024 20:34
@braingram braingram force-pushed the test_suffix branch 2 times, most recently from 6f1fc57 to 35ec996 Compare March 13, 2024 22:10
@braingram
Copy link
Collaborator Author

braingram commented Mar 14, 2024

Regression tests run: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1313/
This shows 25 errors which all look unrelated and caused by:

@hbushouse hbushouse added this to the Build 10.2 milestone Mar 14, 2024
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.31%. Comparing base (4cc0ac1) to head (9abb746).
Report is 26 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8350      +/-   ##
==========================================
+ Coverage   75.15%   75.31%   +0.15%     
==========================================
  Files         470      474       +4     
  Lines       38604    38965     +361     
==========================================
+ Hits        29014    29346     +332     
- Misses       9590     9619      +29     
Flag Coverage Δ *Carryforward flag
nightly 77.33% <ø> (-0.07%) ⬇️ Carriedforward from 4cc0ac1

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hbushouse hbushouse merged commit 155af54 into spacetelescope:master Mar 14, 2024
29 checks passed
@braingram braingram deleted the test_suffix branch March 14, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_suffix.py unit tests skipped
2 participants