Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3589: fixed deprecated code from numpy 2.0 release #8415

Merged
merged 2 commits into from
Apr 10, 2024

Conversation

emolter
Copy link
Collaborator

@emolter emolter commented Apr 9, 2024

Resolves JP-3589

Closes #8400

This PR addresses a few loose-end code deprecations from the new AMI suite and from the numpy 2.0 update.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@emolter
Copy link
Collaborator Author

emolter commented Apr 9, 2024

Regtest run started here

edit: all tests passed

@emolter emolter marked this pull request as ready for review April 9, 2024 21:16
@emolter emolter requested a review from a team as a code owner April 9, 2024 21:16
Copy link

codecov bot commented Apr 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 75.78%. Comparing base (2fb073e) to head (ba2f60e).
Report is 24 commits behind head on master.

Files Patch % Lines
jwst/ami/leastsqnrm.py 0.00% 3 Missing ⚠️
jwst/extract_1d/soss_extract/atoca.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8415      +/-   ##
==========================================
+ Coverage   75.31%   75.78%   +0.47%     
==========================================
  Files         474      476       +2     
  Lines       38965    39450     +485     
==========================================
+ Hits        29345    29897     +552     
+ Misses       9620     9553      -67     
Flag Coverage Δ *Carryforward flag
nightly 77.66% <ø> (+0.32%) ⬆️ Carriedforward from 2fb073e

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hbushouse hbushouse added this to the Build 11.0 milestone Apr 10, 2024
Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. All tests are passing.

@hbushouse hbushouse merged commit 390f1b5 into spacetelescope:master Apr 10, 2024
27 of 28 checks passed
@emolter emolter deleted the JP-3589 branch April 10, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecated code from numpy 2.0 release
2 participants