Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix miri avg_dark regtest #8446

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Conversation

hbushouse
Copy link
Collaborator

@hbushouse hbushouse commented Apr 26, 2024

This PR changes the test of the average_dark capability in the calwebb_detector1 pipeline so that it no longer uses one of the same datasets that's already used in another test in the same regtest module. That causes issues with outputs clobbering one another. All the new input/output files have been loaded to Artifactory and the new regtest passes locally.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.26%. Comparing base (2fb073e) to head (1b7766e).
Report is 41 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #8446       +/-   ##
===========================================
- Coverage   75.31%   56.26%   -19.05%     
===========================================
  Files         474      390       -84     
  Lines       38965    38866       -99     
===========================================
- Hits        29345    21868     -7477     
- Misses       9620    16998     +7378     
Flag Coverage Δ
nightly ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hbushouse hbushouse merged commit fc2b670 into spacetelescope:master Apr 26, 2024
26 of 29 checks passed
@hbushouse hbushouse deleted the fix_regtest branch April 26, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants