-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove hard-coded reference file that uses grp path #8507
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8507 +/- ##
==========================================
+ Coverage 57.93% 57.97% +0.04%
==========================================
Files 387 387
Lines 38839 38830 -9
==========================================
+ Hits 22502 22513 +11
+ Misses 16337 16317 -20 ☔ View full report in Codecov by Sentry. |
good catch, I was thinking this was an issue with our |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that CRDS-525 was resolved over 2 years ago and there are existing NIRSpec extract1d ref files in CRDS, I think it's pretty safe to remove this!
The updated test "fails" with what looks like acceptable differences (in only keyword values related to picking up the new reference file):
|
@hbushouse I triggered the |
@zacharyburnett I also started the github actions regression tests to look for other differences: |
It's my understanding the
/grp
is not accessible on the runners for the github actions regression tests (@zacharyburnett can you confirm this?).This is leading to test failures due to a hard-coded path:
This PR removes the path to allow the test to pick up the latest reference file from crds.
Regression tests running at: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1473/
Checklist for PR authors (skip items if you don't have permissions or they are not applicable)
CHANGES.rst
within the relevant release sectionHow to run regression tests on a PR