Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove hard-coded reference file that uses grp path #8507

Merged
merged 1 commit into from
May 24, 2024

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented May 24, 2024

It's my understanding the /grp is not accessible on the runners for the github actions regression tests (@zacharyburnett can you confirm this?).

This is leading to test failures due to a hard-coded path:

 E           FileNotFoundError: [Errno 2] No such file or directory: '/grp/crds/jwst/references/jwst/jwst_nirspec_extract1d_0001.asdf'

This PR removes the path to allow the test to pick up the latest reference file from crds.

Regression tests running at: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1473/

Checklist for PR authors (skip items if you don't have permissions or they are not applicable)

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • All comments are resolved
  • Make sure the JIRA ticket is resolved properly

Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.97%. Comparing base (781e0e0) to head (4179c09).
Report is 297 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8507      +/-   ##
==========================================
+ Coverage   57.93%   57.97%   +0.04%     
==========================================
  Files         387      387              
  Lines       38839    38830       -9     
==========================================
+ Hits        22502    22513      +11     
+ Misses      16337    16317      -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zacharyburnett
Copy link
Collaborator

good catch, I was thinking this was an issue with our sshfs mount, but if we remove this then we don't have to worry about that

Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that CRDS-525 was resolved over 2 years ago and there are existing NIRSpec extract1d ref files in CRDS, I think it's pretty safe to remove this!

@hbushouse hbushouse added this to the Build 11.0 milestone May 24, 2024
@braingram
Copy link
Collaborator Author

The updated test "fails" with what looks like acceptable differences (in only keyword values related to picking up the new reference file):

AssertionError: 
   fitsdiff: 6.1.0
   a: /data1/jenkins/workspace/RT/JWST-Developers-Pull-Requests/clone/test_outputs/popen-gw5/test_nirspec_lamp_ifu_spec2_rtdata_module0/jw00626030001_02103_00005_nrs1_x1d.fits
   b: /data1/jenkins/workspace/RT/JWST-Developers-Pull-Requests/clone/test_outputs/popen-gw5/test_nirspec_lamp_ifu_spec2_rtdata_module0/truth/jw00626030001_02103_00005_nrs1_x1d.fits
   HDU(s) not to be compared:
    ASDF
   Keyword(s) not to be compared:
    CAL_VCS CAL_VER CRDS_CTX CRDS_VER DATE NAXIS1 TFORM*
   Table column(s) not to be compared:
    CAL_VCS CAL_VER CRDS_CTX CRDS_VER DATE NAXIS1 TFORM*
   Maximum number of different data values to be reported: 10
   Relative tolerance: 1e-05, Absolute tolerance: 1e-07
  
  Primary HDU:
  
     Headers contain differences:
       Keyword R_EXTR1D has different values:
          a> crds://jwst_nirspec_extract1d_0001.asdf
           ? -------
          b> jwst_nirspec_extract1d_0001.asdf
       Keyword R_EXTR1D has different comments:
          a> 1-D extraction parameters
          b> 1-D extraction parameters referen
           ?                          ++++++++
  
assert False
 +  where False = <astropy.io.fits.diff.FITSDiff object at 0x7f190ed6fbc0>.identical

@braingram braingram merged commit 2ff2321 into spacetelescope:master May 24, 2024
29 checks passed
@braingram braingram deleted the no_grp branch May 24, 2024 18:11
@braingram
Copy link
Collaborator Author

@hbushouse I triggered the jwst regression tests to generate files to "okify":
https://plwishmaster.stsci.edu:8081/job/RT/job/JWST/2900/

@braingram
Copy link
Collaborator Author

@zacharyburnett I also started the github actions regression tests to look for other differences:
https://github.com/spacetelescope/RegressionTests/actions/runs/9228220346

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants