Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3624: Fix a source of errors in resampled spec WCS #8511

Merged

Conversation

mcara
Copy link
Member

@mcara mcara commented May 27, 2024

Resolves JP-3624

Closes #8485
Closes #8484

Checklist for PR authors (skip items if you don't have permissions or they are not applicable)

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • All comments are resolved
  • Make sure the JIRA ticket is resolved properly

Regression test: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1479/

@mcara mcara added this to the Build 10.0.1 milestone May 27, 2024
@mcara mcara requested a review from hbushouse May 27, 2024 14:11
@mcara mcara self-assigned this May 27, 2024
@mcara mcara requested a review from a team as a code owner May 27, 2024 14:11
@mcara mcara force-pushed the fix-miri-lrs-resampled-spec-wcs-error branch from ef531f5 to 2d65aa2 Compare May 27, 2024 14:14
Copy link

codecov bot commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.98%. Comparing base (4179c09) to head (2a90f8d).
Report is 321 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #8511    +/-   ##
========================================
  Coverage   57.97%   57.98%            
========================================
  Files         387      388     +1     
  Lines       38830    38930   +100     
========================================
+ Hits        22513    22572    +59     
- Misses      16317    16358    +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hbushouse hbushouse modified the milestones: Build 10.0.1, Build 11.0 May 29, 2024
Copy link
Collaborator

@emolter emolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Single-line code change looks fine to me. Are the regression test differences for test_miri_lrs_slit_spec2 expected? There appear to be changes in a majority of the pixels, and some of them are several percent. Also, I assume you have already ensured that this change does indeed allow the exposures mentioned in the original ticket to be combined? If so, it might be helpful to add a note to the ticket to that effect.

CHANGES.rst Outdated Show resolved Hide resolved
Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with @emolter that I'd very much like to see a visual before/after comparison of an example where it makes only a slight difference, as well as the example observation that was so far off as to trigger the ticket in the first place.

@mcara mcara force-pushed the fix-miri-lrs-resampled-spec-wcs-error branch from 56f965f to bf1aeec Compare May 30, 2024 11:47
@mcara mcara force-pushed the fix-miri-lrs-resampled-spec-wcs-error branch from 58ca7b7 to 2a90f8d Compare May 31, 2024 11:09
Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Examples of new results that are provided in the JP ticket look really good. I approve.

@hbushouse hbushouse merged commit 743160a into spacetelescope:master May 31, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants