-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JP-3642: Fix aperture correction to variance arrays #8530
Conversation
- Split the columns to which aperture correction is applied into the flux columns (flux_cols_to_correct) and the corresponding variance arrays (var_cols_to_correct). Applying the square of the correction factor to the variance arrays.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8530 +/- ##
==========================================
+ Coverage 57.97% 58.02% +0.04%
==========================================
Files 387 388 +1
Lines 38830 38979 +149
==========================================
+ Hits 22513 22618 +105
- Misses 16317 16361 +44 ☔ View full report in Codecov by Sentry. |
Regression tests started at https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1500 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code updates look good. Will wait for regtest results for final approval.
Regression test results show the expected increases in the variance columns of x1d/x1dints files, along with some other unrelated differences. So this looks good. |
Resolves JP-3642
Closes #8521
This PR fixes an error in the application of aperture correction factors to variance arrays in extract1d/apply_apcorr.py. New code splits the columns to which aperture correction is applied into the flux columns (flux_cols_to_correct) and the corresponding variance arrays (var_cols_to_correct). For the latter, it multiplies the square of the correction factor to the variance arrays.
Checklist for PR authors (skip items if you don't have permissions or they are not applicable)
CHANGES.rst
within the relevant release sectionupdated relevant documentationHow to run regression tests on a PR