Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor msa fail/nofail and association duplicate tests to not use caplog #8628

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Jul 3, 2024

The tests updated in this PR randomly fail (likely due to our complex logging and the pytest caplog fixture only using the root logger).

This PR removes the caplog fixture (from only these tests) and replaces it with a monkeypatch of the logger that emits the checked message.

Regression tests running (with jwst_1242.pmap since the new context is causing spec2 failures):
https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1581/
show 0 failures.

Checklist for PR authors (skip items if you don't have permissions or they are not applicable)

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • All comments are resolved
  • Make sure the JIRA ticket is resolved properly

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.56%. Comparing base (d02ac25) to head (ccf871a).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8628   +/-   ##
=======================================
  Coverage   59.56%   59.56%           
=======================================
  Files         391      391           
  Lines       39285    39285           
=======================================
  Hits        23402    23402           
  Misses      15883    15883           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@braingram braingram marked this pull request as ready for review July 4, 2024 04:52
@braingram braingram requested a review from a team as a code owner July 4, 2024 04:52
@braingram braingram requested a review from melanieclarke July 8, 2024 19:24
@braingram braingram mentioned this pull request Jul 10, 2024
8 tasks
@braingram braingram requested a review from zacharyburnett July 11, 2024 13:29
Copy link
Collaborator

@melanieclarke melanieclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me - thanks for addressing these tests, and for providing a general way to check for a specific log message.

@braingram
Copy link
Collaborator Author

Thanks! 🤞 the random failures go away for good.

@braingram braingram merged commit f20f15f into spacetelescope:master Jul 15, 2024
28 checks passed
@braingram braingram deleted the msa_random_failures branch July 15, 2024 15:09
@nden nden added this to the Build 11.1 milestone Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants