Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unlink deleted scripts from build metadata #8659

Merged

Conversation

zacharyburnett
Copy link
Collaborator

@zacharyburnett zacharyburnett commented Jul 18, 2024

removes scripts deleted in #8619 from pyproject.toml project.scripts

Checklist for PR authors (skip items if you don't have permissions or they are not applicable)

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • All comments are resolved
  • Make sure the JIRA ticket is resolved properly

Copy link
Collaborator

@braingram braingram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@zacharyburnett zacharyburnett enabled auto-merge (squash) July 18, 2024 13:25
@zacharyburnett zacharyburnett merged commit 2b0a030 into spacetelescope:master Jul 18, 2024
23 of 25 checks passed
@nden nden added this to the Build 11.1 milestone Jul 20, 2024
@zacharyburnett zacharyburnett deleted the remove/scripts_metadata branch September 23, 2024 17:55
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.23%. Comparing base (80f936a) to head (3445f8c).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8659   +/-   ##
=======================================
  Coverage   60.23%   60.23%           
=======================================
  Files         370      370           
  Lines       38636    38636           
=======================================
  Hits        23272    23272           
  Misses      15364    15364           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants