-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JP-3444: update tso photometry to use ApertureStats #8672
JP-3444: update tso photometry to use ApertureStats #8672
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8672 +/- ##
=======================================
Coverage 60.36% 60.36%
=======================================
Files 372 372
Lines 38326 38326
=======================================
Hits 23137 23137
Misses 15189 15189 ☔ View full report in Codecov by Sentry. |
4d8eee8
to
906202b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me so far. It's a bit hard to evaluate what this change does without some kind of diagnostic plot, e.g., a light curve before and after this PR (plus all of Melanie's changes to NaN handling)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, other than 1 small typo in the change log. We should confirm that they definitely want to ignore NaNs in sources, before we merge, and I agree we should document the choice somwhere.
Just following up - this is now confirmed, in the JP ticket. |
a369665
to
80c478f
Compare
@melanieclarke Could you look at the statement I put in the documentation. Does that sound ok ? |
b0067fa
to
3cb6627
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple quick typos to fix, but otherwise, I think this is ready.
Resolves JP-3444
Closes #8019
This PR addresses when there are nans in the aperture for determining tso photometry. The resulting
ecsv file contained NaN values. This update uses the photutils function ApertureStats that screens
for Nan values.
Checklist for PR authors (skip items if you don't have permissions or they are not applicable)
added entry in
CHANGES.rst
within the relevant release sectionupdated or added relevant tests
updated relevant documentation
added relevant milestone
added relevant label(s)
ran regression tests, post a link to the Jenkins job below.
How to run regression tests on a PR
https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1620/
All comments are resolved
Make sure the JIRA ticket is resolved properly