JP-3730: Re-enable saving of blot models during outlier detection

[emolter]

Resolves JP-3730

Closes #8750

Recent work refactoring the memory management within the outlier detection step had disabled the creation of blot files as optional intermediate-stage outputs. This PR reverts this removal, allowing these blot models to be saved when save_intermediate_results is True.

Checklist for PR authors (skip items if you don't have permissions or they are not applicable)

• added entry in CHANGES.rst within the relevant release section
• updated or added relevant tests
• updated relevant documentation
• added relevant milestone
• added relevant label(s)
• ran regression tests, post a link to the Jenkins job below.
  How to run regression tests on a PR
• All comments are resolved
• Make sure the JIRA ticket is resolved properly

[emolter]

regression tests started here

[codecov]

Codecov Report

Attention: Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.

Project coverage is 60.84%. Comparing base (e16c058) to head (8350208).

Files with missing lines	Patch %	Lines
jwst/outlier_detection/spec.py	0.00%	1 Missing ⚠️
jwst/outlier_detection/utils.py	93.33%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #8758      +/-   ##
==========================================
+ Coverage   60.83%   60.84%   +0.01%     
==========================================
  Files         373      373              
  Lines       38636    38650      +14     
==========================================
+ Hits        23503    23516      +13     
- Misses      15133    15134       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[emolter]

Regression test failures match the 4 failed tests from last night's run on main, so they aren't caused by this PR.

[melanieclarke]

I think this looks right, but handling needs to be added to the spectral mode as well, since resampling is also done there. I can test with real data when that's done.

[melanieclarke]

These changes look good to me.

Testing on some spectral data I have around (jw02361-o010_20240207t162649_spec3_00001_asn.json), the blot files look like they are written out appropriately.

However, thinking about it some more, I think we should really just save the SCI array instead of copying the entire input model and setting DQ and ERR to zero. As is, the variance arrays are included but left unchanged, and there are several other unrelated arrays that don't need to be in the blot product (flatfield, pathloss, photom, etc.).

Can we change this to make the blot product closer to the median and outlier_s2d products, and just write out the SCI array?

[emolter]

@melanieclarke the most recent change to the _make_blot_model() helper function should contain the change you suggest. I tested it on some imaging data- the only extensions are now PRIMARY, SCI, and ASDF, and the data look the same as they did before the change.

[melanieclarke]

Okay, everything looks good to me. Testing again on my spectral data set, only the sci array is written and metadata is updated, save location and file names look right. I also checked a random imaging data set from the regtest data and that looks right too. Thanks!