-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JP-3729: report jwst version at end of Step.run #8769
JP-3729: report jwst version at end of Step.run #8769
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8769 +/- ##
=======================================
Coverage 60.84% 60.85%
=======================================
Files 373 373
Lines 38654 38657 +3
=======================================
+ Hits 23518 23523 +5
+ Misses 15136 15134 -2 ☔ View full report in Codecov by Sentry. |
Testing with single steps (skipped and not skipped) and with whole pipelines, it looks like this works. It is a little different from the previous implementation -- the log message comes from stpipe instead of from the step or pipeline interface, and it's printed at the end instead of next to the CRDS context message. Is that okay, @drlaw1558? |
f11a4fb
to
8f6814f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG2M, print location should be fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
This is a second attempt at logging the jwst version at the end of pipeline/step runs. The first attempt was subject to a stpipe bug which will need to be separately addressed.
This PR wraps
Step.run
to log the version at the end of a run for a step that has no parent. This is similar to the previous attempt #8760 but does not usefinalize_result
(as that is called incorrectly by stpipe).Testing with
strun nsclean abcdefg
(to make sure this works around the stpipe bug: spacetelescope/stpipe#188) gives:Resolves JP-3729
Tasks
Build 11.3
(use the latest build if not sure)CHANGES.rst
within the relevant release section (otherwise add theno-changelog-entry-needed
label to this PR)docs/
pageokify_regtests
to update the truth files