Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify Dark Reference File #291

Closed
tddesjardins opened this issue Jul 12, 2023 · 2 comments · Fixed by #323
Closed

Modify Dark Reference File #291

tddesjardins opened this issue Jul 12, 2023 · 2 comments · Fixed by #323
Assignees
Labels

Comments

@tddesjardins
Copy link

To support proper propagation of uncertainties from the dark subtraction, RTB would like to request the following changes to the dark reference file schema:

  1. Add an array called "dark_slope" that is float32 and has Ndim = 2 with units of DN / second.
  2. Change the "err" array to have Ndim = 2 (data type and units are fine as is). After discussion with @schlafly we are open to changing the name of this to be more descriptive as well. This should be the uncertainty in the slope estimate of the dark. Suggestions for the name are welcome in the comments, e.g., "dark_slope_err".
@schlafly
Copy link
Collaborator

Let's chat about this a little at the tag up today. In spacetelescope/romancal#772 I detach the dark subtraction step from stcal, which would make this especially easy to support.

@schlafly
Copy link
Collaborator

RTB documentation is here: https://innerspace.stsci.edu/display/RI/Dark+Subtraction+-+v2
I vote for dark_slope_err, since we seem to use "err" preferenentially to "var" for reference files. I don't think we should just do "err" since that would imply that this is the error on "data" rather than on the new dark_slope quantity.

@PaulHuwe PaulHuwe self-assigned this Oct 19, 2023
@PaulHuwe PaulHuwe linked a pull request Oct 19, 2023 that will close this issue
4 tasks
@PaulHuwe PaulHuwe closed this as completed Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants