-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use same changelog workflow as the rest of the roman repositories #772
Use same changelog workflow as the rest of the roman repositories #772
Conversation
The independent workflow is managed by @pllim. |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #772 +/- ##
=======================================
Coverage 76.91% 76.91%
=======================================
Files 90 90
Lines 5467 5467
=======================================
Hits 4205 4205
Misses 1262 1262
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
FWIW Brigitta asked if I am interested to upstream this to Scientific Python but I was hesitant because I am scared it is going to get refactored and break stuff. But if STScI is not comfortable with this workflow in my own account, I can revisit that idea with Brigitta. It should not go under spacetelescope because it is used by Astropy too. |
c51ac3f
to
824ee52
Compare
824ee52
to
de8973a
Compare
would it be possible to put it under OpenAstronomy? |
We can fork and change it if it starts breaking stuff for space telescope. |
I am not a member of OpenAstronomy |
Let me ask around. But in the meantime, nothing stops you from using it as-is right now. |
Its used by the rest of roman, asdf, and jdaviz... so we (STScI) have motivation to fork back if there ends up being an issue like you fear. |
Yeah but even if I move it, the existing call would still work. So no reason to wait around for a political move here. |
I'll probably just batch PR to all the affected repos when the move happens. |
Well, just to chime in, the format is used in my repos, too, so I'm motivated enough not to break the current format :) |
This PR updates the changelog CI to use the same changelog workflow used by
rad
androman_datamodels
. This workflow draws from an independent centralized workflow that has several additional features (including milestone verification if we wish to turn that on).Checklist
CHANGES.rst
under the corresponding subsection