Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use same changelog workflow as the rest of the roman repositories #772

Merged

Conversation

WilliamJamieson
Copy link
Collaborator

This PR updates the changelog CI to use the same changelog workflow used by rad and roman_datamodels. This workflow draws from an independent centralized workflow that has several additional features (including milestone verification if we wish to turn that on).

Checklist

  • added entry in CHANGES.rst under the corresponding subsection
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)

@WilliamJamieson WilliamJamieson requested a review from a team as a code owner July 5, 2023 19:34
@WilliamJamieson
Copy link
Collaborator Author

The independent workflow is managed by @pllim.

@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (addb5de) 76.91% compared to head (de8973a) 76.91%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #772   +/-   ##
=======================================
  Coverage   76.91%   76.91%           
=======================================
  Files          90       90           
  Lines        5467     5467           
=======================================
  Hits         4205     4205           
  Misses       1262     1262           
Flag Coverage Δ *Carryforward flag
nightly 64.72% <ø> (ø) Carriedforward from 0d15352

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pllim
Copy link
Contributor

pllim commented Jul 5, 2023

FWIW Brigitta asked if I am interested to upstream this to Scientific Python but I was hesitant because I am scared it is going to get refactored and break stuff. But if STScI is not comfortable with this workflow in my own account, I can revisit that idea with Brigitta. It should not go under spacetelescope because it is used by Astropy too.

@WilliamJamieson WilliamJamieson force-pushed the update/changelog_ci branch 2 times, most recently from c51ac3f to 824ee52 Compare July 6, 2023 13:46
@zacharyburnett
Copy link
Collaborator

FWIW Brigitta asked if I am interested to upstream this to Scientific Python but I was hesitant because I am scared it is going to get refactored and break stuff. But if STScI is not comfortable with this workflow in my own account, I can revisit that idea with Brigitta. It should not go under spacetelescope because it is used by Astropy too.

would it be possible to put it under OpenAstronomy?

@WilliamJamieson
Copy link
Collaborator Author

FWIW Brigitta asked if I am interested to upstream this to Scientific Python but I was hesitant because I am scared it is going to get refactored and break stuff. But if STScI is not comfortable with this workflow in my own account, I can revisit that idea with Brigitta. It should not go under spacetelescope because it is used by Astropy too.

We can fork and change it if it starts breaking stuff for space telescope.

@pllim
Copy link
Contributor

pllim commented Jul 7, 2023

I am not a member of OpenAstronomy

@pllim
Copy link
Contributor

pllim commented Jul 7, 2023

Let me ask around. But in the meantime, nothing stops you from using it as-is right now.

@WilliamJamieson
Copy link
Collaborator Author

Let me ask around. But in the meantime, nothing stops you from using it as-is right now.

Its used by the rest of roman, asdf, and jdaviz... so we (STScI) have motivation to fork back if there ends up being an issue like you fear.

@pllim
Copy link
Contributor

pllim commented Jul 7, 2023

Yeah but even if I move it, the existing call would still work. So no reason to wait around for a political move here.

@pllim
Copy link
Contributor

pllim commented Jul 7, 2023

I'll probably just batch PR to all the affected repos when the move happens.

@bsipocz
Copy link

bsipocz commented Jul 7, 2023

FWIW Brigitta asked if I am interested to upstream this to Scientific Python but I was hesitant because I am scared it is going to get refactored and break stuff.

Well, just to chime in, the format is used in my repos, too, so I'm motivated enough not to break the current format :)

@WilliamJamieson WilliamJamieson merged commit 29c5b19 into spacetelescope:main Jul 10, 2023
@WilliamJamieson WilliamJamieson deleted the update/changelog_ci branch July 10, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants