Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pass to pass_number #360

Closed

Conversation

WilliamJamieson
Copy link
Collaborator

Closes #349

This PR renames pass to pass_number as pass is a reserved word in python for syntax

Checklist

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.38%. Comparing base (0fb1239) to head (b72f18b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #360   +/-   ##
=======================================
  Coverage   95.38%   95.38%           
=======================================
  Files           4        4           
  Lines         195      195           
=======================================
  Hits          186      186           
  Misses          9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@PaulHuwe PaulHuwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nden nden added this to the Build 13 milestone Jan 25, 2024
@WilliamJamieson WilliamJamieson force-pushed the bugfix/pass branch 2 times, most recently from cc2f695 to 5e2e3aa Compare February 7, 2024 15:06
@WilliamJamieson WilliamJamieson force-pushed the bugfix/pass branch 5 times, most recently from 989fc85 to b500a4f Compare February 13, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change pass -> pass_number in schemas
4 participants