Adding schema for Source Catalog #374
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| %YAML 1.1 | ||
| --- | ||
| $schema: asdf://stsci.edu/datamodels/roman/schemas/rad_schema-1.0.0 | ||
| id: asdf://stsci.edu/datamodels/roman/schemas/segmentation_map-1.0.0 | ||
|
|
||
| title: Segmentation map generated by the Source Catalog Step. | ||
|
|
||
| datamodel_name: SegmentationMapModel | ||
|
|
||
| archive_meta: None | ||
| type: object | ||
| properties: | ||
| meta: | ||
| allOf: | ||
| - type: object | ||
| properties: | ||
| basic: | ||
| tag: asdf://stsci.edu/datamodels/roman/tags/mosaic_basic-1.0.0 | ||
| coordinates: | ||
| tag: asdf://stsci.edu/datamodels/roman/tags/coordinates-1.0.0 | ||
| program: | ||
| tag: asdf://stsci.edu/datamodels/roman/tags/program-1.0.0 | ||
| wcsinfo: | ||
| tag: asdf://stsci.edu/datamodels/roman/tags/mosaic_wcsinfo-1.0.0 | ||
| required: [basic, coordinates, program, wcsinfo] | ||
| data: | ||
| title: Segmentation map | ||
| description: | | ||
| Segmentation map of an image model, zeros correspond to background. | ||
| tag: tag:stsci.edu:asdf/core/ndarray-1.* | ||
| ndim: 2 | ||
| datatype: uint32 | ||
| exact_datatype: true | ||
|
|
||
| required: [meta, data] | ||
| flowStyle: block | ||
| propertyOrder: [meta, data] | ||
| ... |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| %YAML 1.1 | ||
| --- | ||
| $schema: asdf://stsci.edu/datamodels/roman/schemas/rad_schema-1.0.0 | ||
| id: asdf://stsci.edu/datamodels/roman/schemas/source_catalog-1.0.0 | ||
|
|
||
| title: Source catalog generated by the Source Catalog Step. | ||
|
|
||
| datamodel_name: SourceCatalogModel | ||
|
|
||
| archive_meta: None | ||
| type: object | ||
| properties: | ||
|
There was a problem hiding this comment. General questions: Since this is a data model should it have a There was a problem hiding this comment. I don't know yet – I'll follow up when I get directions from RTB. |
||
| meta: | ||
|
There was a problem hiding this comment. Could you please put meta above the binary contents for both this and There was a problem hiding this comment. Yikes, order matters? There was a problem hiding this comment. Doesn't matter code-wise (nor in the end file, you.. you set that order below). More about readability of schemas. |
||
| allOf: | ||
| - type: object | ||
| properties: | ||
| basic: | ||
| tag: asdf://stsci.edu/datamodels/roman/tags/mosaic_basic-1.0.0 | ||
| coordinates: | ||
| tag: asdf://stsci.edu/datamodels/roman/tags/coordinates-1.0.0 | ||
| photometry: | ||
| tag: asdf://stsci.edu/datamodels/roman/tags/photometry-1.0.0 | ||
| program: | ||
| tag: asdf://stsci.edu/datamodels/roman/tags/program-1.0.0 | ||
| wcsinfo: | ||
| tag: asdf://stsci.edu/datamodels/roman/tags/mosaic_wcsinfo-1.0.0 | ||
| required: [basic, coordinates, photometry, program, wcsinfo] | ||
| source_catalog: | ||
| title: Source Catalog | ||
| description: | | ||
| Photometry and astrometry computed in the Source Catalog Step. | ||
| tag: tag:astropy.org:astropy/table/table-1.* | ||
|
|
||
| required: [meta, source_catalog] | ||
| flowStyle: block | ||
| propertyOrder: [meta, source_catalog] | ||
bmorris3 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| ... | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
archive_meta is used to indicate this is the entry point for storing data in the db (e.g. wfi_image-1.0.0.yaml, guidewindow-1.0.0.yaml, etc.) Is this such a file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The honest answer is: I don't know. I'm waiting on instructions from RTB on these specs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kdupriestsci The source catalogs and the segmentation maps are officially a data product that needs to be stored in the archive. They are new products we are developing now but "at the level of wfi_image". Does this answer your question? What would be the value of this keyword then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nden I'm not sure what you mean by "at the level of wfi_image". If they are their own files and not part of the wfi_image file then having the archive_meta: None is correct (we are not yet assigning a value to this keyword yet, we're just checking for its existence.
Please note that we don't have filetypes for Segmentation Maps or Source Catalogs in the archive (unless they're going under a different name), so this will require coordination with the db (either Azure or Oak, depending on who's doing it).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kdupriestsci Sorry for the bad terminology. By "at the same level as wfi_image" I meant that these will be separate files. And thanks for clarifying the correct value in this case is
None.@ddavis-stsci @schlafly Could you coordinate with the rest of the team the work on the filetypes in the DB?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should bring this up in the RAD group but I think the correct filetype will be "Science WFI Level 4", FileTypeID=64.