Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ground test docs schema list #447

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Sep 20, 2024

The schema list in the ground tests docs isn't rendering:
https://rad.readthedocs.io/en/latest/ground_tests.html

This PR fixes the formatting to allow them to render:
https://rad--447.org.readthedocs.build/en/447/ground_tests.html

Closes: #444

Tasks

  • Update or add relevant rad tests.
  • Update relevant docstrings and / or docs/ page.
  • Does this PR change any schema files?
    • Schema changes were discussed at RAD Review Board meeting.
  • Does this PR change any API used downstream? (If not, label with no-changelog-entry-needed.)
News fragment change types:
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.misc.rst: infrastructure or miscellaneous change

@braingram braingram requested a review from a team as a code owner September 20, 2024 17:44
@braingram
Copy link
Collaborator Author

I'd say this doesn't need a changelog but can't add the label. If a changelog is preferred let me know.

Pinging @PaulHuwe for review.

Copy link
Collaborator

@PaulHuwe PaulHuwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.45%. Comparing base (c1811ab) to head (922862a).
Report is 187 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #447      +/-   ##
==========================================
+ Coverage   95.38%   95.45%   +0.06%     
==========================================
  Files           4        4              
  Lines         195      198       +3     
==========================================
+ Hits          186      189       +3     
  Misses          9        9              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@braingram braingram mentioned this pull request Sep 21, 2024
8 tasks
@PaulHuwe
Copy link
Collaborator

The second part of this PR is fixing #444

@braingram braingram merged commit f3648f3 into spacetelescope:main Sep 26, 2024
13 of 14 checks passed
@braingram braingram deleted the docs_ground_test branch September 26, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix FPS / TVAC Documentation
2 participants