-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RAD-175: Add ePSF, ABVegaOffset, and ApCorr Schemas #452
Merged
Merged
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
4fd2116
Initial commit.
PaulHuwe 72fb9be
Added Changelog.
PaulHuwe e0c5de5
Merge branch 'main' of https://github.com/spacetelescope/rad into RAD…
PaulHuwe 12576f9
Simplified schemas.
PaulHuwe 0dd5c38
Addressed PR comments.
PaulHuwe 4e79820
Merge branch 'main' into RAD-175_PSFetalSchema
PaulHuwe 4496f10
Update src/rad/resources/schemas/reference_files/epsf-1.0.0.yaml
PaulHuwe 3127e72
Merge branch 'main' into RAD-175_PSFetalSchema
PaulHuwe f256f30
Merge branch 'main' into RAD-175_PSFetalSchema
PaulHuwe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Added ePSF, ABVegaOffset, and ApCorr schemas |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
137 changes: 137 additions & 0 deletions
137
src/rad/resources/schemas/reference_files/abvegaoffset-1.0.0.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,137 @@ | ||
%YAML 1.1 | ||
--- | ||
$schema: asdf://stsci.edu/datamodels/roman/schemas/rad_schema-1.0.0 | ||
id: asdf://stsci.edu/datamodels/roman/schemas/reference_files/abvegaoffset-1.0.0 | ||
|
||
title: AB Vega Offset Reference File Schema | ||
|
||
datamodel_name: AbvegaoffsetRefModel | ||
|
||
type: object | ||
properties: | ||
meta: | ||
allOf: | ||
- $ref: ref_common-1.0.0 | ||
- type: object | ||
properties: | ||
reftype: | ||
type: string | ||
enum: [ABVEGAOFFSET] | ||
data: | ||
type: object | ||
properties: | ||
DARK: | ||
type: object | ||
properties: | ||
abvega_offset: | ||
title: AB-Vega Magntiude Offset | ||
description: Magnitude difference between the AB and Vega magnitude | ||
systems. Found by calculating the AB magnitude of Vega within | ||
the DARK optical element bandpass. | ||
type: number | ||
required: [abvega_offset] | ||
F062: | ||
type: object | ||
properties: | ||
abvega_offset: | ||
title: AB-Vega Magntiude Offset | ||
description: Magnitude difference between the AB and Vega magnitude | ||
systems. Found by calculating the AB magnitude of Vega within | ||
the F062 optical element bandpass. | ||
type: number | ||
required: [abvega_offset] | ||
F087: | ||
type: object | ||
properties: | ||
abvega_offset: | ||
title: AB-Vega Magntiude Offset | ||
description: Magnitude difference between the AB and Vega magnitude | ||
systems. Found by calculating the AB magnitude of Vega within | ||
the F087 optical element bandpass. | ||
type: number | ||
required: [abvega_offset] | ||
F106: | ||
type: object | ||
properties: | ||
abvega_offset: | ||
title: AB-Vega Magntiude Offset | ||
description: Magnitude difference between the AB and Vega magnitude | ||
systems. Found by calculating the AB magnitude of Vega within | ||
the F106 optical element bandpass. | ||
type: number | ||
required: [abvega_offset] | ||
F129: | ||
type: object | ||
properties: | ||
abvega_offset: | ||
title: AB-Vega Magntiude Offset | ||
description: Magnitude difference between the AB and Vega magnitude | ||
systems. Found by calculating the AB magnitude of Vega within | ||
the F129 optical element bandpass. | ||
type: number | ||
required: [abvega_offset] | ||
F146: | ||
type: object | ||
properties: | ||
abvega_offset: | ||
title: AB-Vega Magntiude Offset | ||
description: Magnitude difference between the AB and Vega magnitude | ||
systems. Found by calculating the AB magnitude of Vega within | ||
the F146 optical element bandpass. | ||
type: number | ||
required: [abvega_offset] | ||
F158: | ||
type: object | ||
properties: | ||
abvega_offset: | ||
title: AB-Vega Magntiude Offset | ||
description: Magnitude difference between the AB and Vega magnitude | ||
systems. Found by calculating the AB magnitude of Vega within | ||
the F158 optical element bandpass. | ||
type: number | ||
required: [abvega_offset] | ||
F184: | ||
type: object | ||
properties: | ||
abvega_offset: | ||
title: AB-Vega Magntiude Offset | ||
description: Magnitude difference between the AB and Vega magnitude | ||
systems. Found by calculating the AB magnitude of Vega within | ||
the F184 optical element bandpass. | ||
type: number | ||
required: [abvega_offset] | ||
F213: | ||
type: object | ||
properties: | ||
abvega_offset: | ||
title: AB-Vega Magntiude Offset | ||
description: Magnitude difference between the AB and Vega magnitude | ||
systems. Found by calculating the AB magnitude of Vega within | ||
the F213 optical element bandpass. | ||
type: number | ||
required: [abvega_offset] | ||
GRISM: | ||
type: object | ||
properties: | ||
abvega_offset: | ||
title: AB-Vega Magntiude Offset | ||
description: Magnitude difference between the AB and Vega magnitude | ||
systems. Found by calculating the AB magnitude of Vega within | ||
the GRISM optical element bandpass. | ||
type: number | ||
required: [abvega_offset] | ||
PRISM: | ||
type: object | ||
properties: | ||
abvega_offset: | ||
title: AB-Vega Magntiude Offset | ||
description: Magnitude difference between the AB and Vega magnitude | ||
systems. Found by calculating the AB magnitude of Vega within | ||
the PRISM optical element bandpass. | ||
type: number | ||
required: [abvega_offset] | ||
required: [DARK, F062, F087, F106, F129, F146, F158, F184, F213, GRISM, PRISM] | ||
required: [meta, data] | ||
flowStyle: block | ||
propertyOrder: [meta, data] | ||
... |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tddesjardins , just for my edification, we do not currently ever plan to use these in the pipeline? These are the integrals over the full grism data, so that if that were a magnitude we ever computed, this would be the AB-Vega magnitude offset?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not aware of anything in the exposure or mosaic pipelines that would use this file. I was just chatting with Will, and I think in theory this could be used for L4 source catalogs or for user reference. (Frankly, I was questioning why this information just isn't in the photom file.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that the AB - Vega offsets could also go in the photom files. If we're duplicating Webb that's fine motivation for keeping it separate, but I agree that this is very parallel to the information in the photom files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is my understanding that this is what Webb did, but I would be in favor of combining the reference files instead of having 1 very basic file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would also prefer this in PHOTOM, but, it appears to be separate in JWST:
https://github.com/spacetelescope/jwst/blob/e5c73fa23d157f4aa65416b4070c2b838e978494/docs/jwst/references_general/abvegaoffset_reffile.inc