Construct ModelContainer from a Sequence

[bmorris3]

It's occasionally convenient to construct a ModelContainer with an init arg that may be either (1) a string path/DataModel; or also (2) an existing ModelContainer instance. (1) is currently supported in roman_datamodels and jwst, while (2) is supported in jwst but not roman_datamodels.

In this tiny PR, I've allowed rdm ModelContainers to be constructed from lists or subclasses of collections.abc.Sequence, so that the expected behavior is recovered.

Checklist

• Added entry in CHANGES.rst under the corresponding subsection
• updated relevant tests
• updated relevant documentation
• Passed romancal regression testing on Jenkins / PLWishMaster. Link: https://plwishmaster.stsci.edu:8081/job/RT/job/romancal/XXX/

[codecov]

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (c4557bb) 96.72% compared to head (e1f319f) 96.74%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #164      +/-   ##
==========================================
+ Coverage   96.72%   96.74%   +0.01%     
==========================================
  Files           8        8              
  Lines        1100     1106       +6     
==========================================
+ Hits         1064     1070       +6     
  Misses         36       36              

Impacted Files	Coverage Δ
tests/test_models.py	98.22% <100.00%> (+0.02%)	⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[PaulHuwe]

Please update the Change log.

[PaulHuwe]

In addition, you need to add the PLWishMaster regression test run.

[mairanteodoro]

Looks good to me.

[bmorris3]

@PaulHuwe Here's the regression test. And thanks again for the help!

[WilliamJamieson]

Also fix the merge conflict in CHANGES.rst

[WilliamJamieson]

Suggested change

	elif isinstance(init, (list, Sequence)):
	elif isinstance(init, Iterable):

This will allow it to handle anything that follows the iterable protocol, the later checks will cover off any cases where this does not make sense.

Note Iterable is a part of the abc.collections builtin Python module, so line 16 will need to be updated in addition to this change in order for it to work.

[PaulHuwe]

LGTM with @WilliamJamieson's comments.

[bmorris3]

I'll rebase to fix the new conflict, but @PaulHuwe / @WilliamJamieson: could you confirm that the last remaining test failure is unrelated? Thanks.

[WilliamJamieson]

I'll rebase to fix the new conflict, but @PaulHuwe / @WilliamJamieson: could you confirm that the last remaining test failure is unrelated? Thanks.

The failure should have been fixed by #174. Try rebasing again with those changes included.

[WilliamJamieson]

I'm merging this before anything else breaks stuff (I think spacetelescope/rad#255 just did but the CI is green now).

[bmorris3]

Thanks @WilliamJamieson et al!