Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devdeps failing with "ModuleNotFoundError: No module named 'pyarrow'" #1481

Closed
braingram opened this issue Oct 30, 2024 · 4 comments · Fixed by #1496
Closed

devdeps failing with "ModuleNotFoundError: No module named 'pyarrow'" #1481

braingram opened this issue Oct 30, 2024 · 4 comments · Fixed by #1496

Comments

@braingram
Copy link
Collaborator

braingram commented Oct 30, 2024

https://github.com/spacetelescope/romancal/actions/runs/11598260944/job/32293762396#step:10:922

I believe this may be due to the use of a development version of astropy.

This also appears in the downstream/devdeps testing in stcal:
https://github.com/spacetelescope/stcal/actions/runs/11597106821/job/32289791188#step:10:745

Is it necessary/useful to test all of these formats?

list_of_supported_formats.remove(x)
for x in [
"asdf",
"fits",
"hdf5",
"parquet",
"pandas.html",
"pandas.json",
"pandas.csv",
]

It seems like more a test of astropy than anything romancal related.

@braingram
Copy link
Collaborator Author

@mairanteodoro is there a requirement to test all these formats? If so we may need to add some more test dependencies.

@mairanteodoro
Copy link
Collaborator

@mairanteodoro is there a requirement to test all these formats? If so we may need to add some more test dependencies.

Not that I know of, @braingram.
I think we can reduce that list down to the ones we use the most (i.e., asdf & fits, as far as I'm concerned).

@schlafly
Copy link
Collaborator

schlafly commented Nov 1, 2024

Confirming, yes, we need only support a small number of formats, maybe fits and ecsv. asdf is also good though I actually don't know what schema would be being used for that catalog. @mairanteodoro , if you have time, cleaning this up to be more minimal so it doesn't affect devdeps testing would be great, thanks.

@mairanteodoro
Copy link
Collaborator

Work done in PR#1496.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants