-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce the number of tests for supported catalog formats. #1496
Conversation
"pandas.csv", | ||
] | ||
] | ||
list_of_supported_formats = ["ascii.ecsv", "fits"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What would be required to add asdf
?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1496 +/- ##
=======================================
Coverage 76.20% 76.20%
=======================================
Files 115 115
Lines 7631 7631
=======================================
Hits 5815 5815
Misses 1816 1816 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Fixes the devdeps failure (the 2 remaining failures are the python 3.13 ones which won't run because of scikit-image).
I left a comment about supporting asdf
. As it wasn't a supported format before I'd say a separate PR makes sense.
FWIW, it looks to me like asdf round-trips fine (tab.write('blah.asdf') ; tab = Table.read('blah.asdf')) seems fine to me. So I would have guessed that we could include it as a format without additional effort. |
The
I didn't try changing that so there may be other hurdles. |
50788fc
to
63c3ae9
Compare
63c3ae9
to
b353854
Compare
Closes #1481
This PR reduces the number of supported formats to be tested in the unit test runs. It doesn't mean we're reducing the number of actual supported formats, which should be the same as those supported by
astropy
'stable.Table
class (full list can be created by runningTable.write.list_formats()
).Regression tests
All regtests are passing:
Tasks
24Q4_B15
(use the latest build if not sure)no-changelog-entry-needed
)changes/
:echo "changed something" > changes/<PR#>.<changetype>.rst
(see below for change types)docs/
pageokify_regtests
to update the truth filesnews fragment change types...
changes/<PR#>.general.rst
: infrastructure or miscellaneous changechanges/<PR#>.docs.rst
changes/<PR#>.stpipe.rst
changes/<PR#>.associations.rst
changes/<PR#>.scripts.rst
changes/<PR#>.mosaic_pipeline.rst
changes/<PR#>.patch_match.rst
steps
changes/<PR#>.dq_init.rst
changes/<PR#>.saturation.rst
changes/<PR#>.refpix.rst
changes/<PR#>.linearity.rst
changes/<PR#>.dark_current.rst
changes/<PR#>.jump_detection.rst
changes/<PR#>.ramp_fitting.rst
changes/<PR#>.assign_wcs.rst
changes/<PR#>.flatfield.rst
changes/<PR#>.photom.rst
changes/<PR#>.flux.rst
changes/<PR#>.source_detection.rst
changes/<PR#>.tweakreg.rst
changes/<PR#>.skymatch.rst
changes/<PR#>.outlier_detection.rst
changes/<PR#>.resample.rst
changes/<PR#>.source_catalog.rst