Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the number of tests for supported catalog formats. #1496

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

mairanteodoro
Copy link
Collaborator

@mairanteodoro mairanteodoro commented Nov 5, 2024

Closes #1481

This PR reduces the number of supported formats to be tested in the unit test runs. It doesn't mean we're reducing the number of actual supported formats, which should be the same as those supported by astropy's table.Table class (full list can be created by running Table.write.list_formats()).

Regression tests

All regtests are passing:

Tasks

  • request a review from someone specific, to avoid making the maintainers review every PR
  • add a build milestone, i.e. 24Q4_B15 (use the latest build if not sure)
  • Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly
news fragment change types...
  • changes/<PR#>.general.rst: infrastructure or miscellaneous change
  • changes/<PR#>.docs.rst
  • changes/<PR#>.stpipe.rst
  • changes/<PR#>.associations.rst
  • changes/<PR#>.scripts.rst
  • changes/<PR#>.mosaic_pipeline.rst
  • changes/<PR#>.patch_match.rst

steps

  • changes/<PR#>.dq_init.rst
  • changes/<PR#>.saturation.rst
  • changes/<PR#>.refpix.rst
  • changes/<PR#>.linearity.rst
  • changes/<PR#>.dark_current.rst
  • changes/<PR#>.jump_detection.rst
  • changes/<PR#>.ramp_fitting.rst
  • changes/<PR#>.assign_wcs.rst
  • changes/<PR#>.flatfield.rst
  • changes/<PR#>.photom.rst
  • changes/<PR#>.flux.rst
  • changes/<PR#>.source_detection.rst
  • changes/<PR#>.tweakreg.rst
  • changes/<PR#>.skymatch.rst
  • changes/<PR#>.outlier_detection.rst
  • changes/<PR#>.resample.rst
  • changes/<PR#>.source_catalog.rst

"pandas.csv",
]
]
list_of_supported_formats = ["ascii.ecsv", "fits"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would be required to add asdf?

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.20%. Comparing base (7999a59) to head (b353854).
Report is 149 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1496   +/-   ##
=======================================
  Coverage   76.20%   76.20%           
=======================================
  Files         115      115           
  Lines        7631     7631           
=======================================
  Hits         5815     5815           
  Misses       1816     1816           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@braingram braingram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Fixes the devdeps failure (the 2 remaining failures are the python 3.13 ones which won't run because of scikit-image).

I left a comment about supporting asdf. As it wasn't a supported format before I'd say a separate PR makes sense.

@schlafly
Copy link
Collaborator

schlafly commented Nov 6, 2024

FWIW, it looks to me like asdf round-trips fine (tab.write('blah.asdf') ; tab = Table.read('blah.asdf')) seems fine to me. So I would have guessed that we could include it as a format without additional effort.

@braingram
Copy link
Collaborator

braingram commented Nov 6, 2024

FWIW, it looks to me like asdf round-trips fine (tab.write('blah.asdf') ; tab = Table.read('blah.asdf')) seems fine to me. So I would have guessed that we could include it as a format without additional effort.

The overwrite argument here causes the asdf format to fail:

ref_table.write(output, format=table_format, overwrite=True)

I didn't try changing that so there may be other hurdles.

@mairanteodoro mairanteodoro force-pushed the mairanteodoro-patch-2 branch 2 times, most recently from 50788fc to 63c3ae9 Compare November 6, 2024 19:04
@mairanteodoro mairanteodoro merged commit 78d5e0f into main Nov 7, 2024
42 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

devdeps failing with "ModuleNotFoundError: No module named 'pyarrow'"
3 participants