Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update photom step for WFI data #152

Closed
stscijgbot-rstdms opened this issue Feb 23, 2021 · 6 comments · Fixed by #469
Closed

Update photom step for WFI data #152

stscijgbot-rstdms opened this issue Feb 23, 2021 · 6 comments · Fixed by #469
Labels
Photom team_periwinkle
Milestone
Build 0.6 (22Q3_B6)

Comments

@stscijgbot-rstdms
Copy link
Collaborator

stscijgbot-rstdms commented Feb 23, 2021 •
edited
Loading

Issue RCAL-112 was created on JIRA by David Davis:

Implement photom step for WFI.

https://innerspace.stsci.edu/pages/viewpage.action?spaceKey=RI&title=Absolute+Photometric+Calibration+-+v1
@ddavis-stsci ddavis-stsci added this to the Build 0.2 milestone Mar 4, 2021
@ddavis-stsci ddavis-stsci modified the milestones: Build 0.2, Build 0.3 Jun 4, 2021
@stscijgbot-rstdms
Copy link
Collaborator Author

Comment by Erica Kolatch on JIRA:

Megan Sosey and David Davis - I am confused by this ticket.  It has a Resolution of Done and a status of Open.  Has this work actually been done?  

@stscijgbot-rstdms
Copy link
Collaborator Author

Comment by Megan Sosey on JIRA:

Erica Kolatch the RCAL project does not have a status of "ToDo", "Open" is there starting status (see the workflow). So tickets that you see as "Open" have not been started yet. I don't know why the "Done" is listed on this ticket without having progressed through the workflow, there are a range of unstarted tickets like this.

@stscijgbot-rstdms
Copy link
Collaborator Author

Comment by Erica Kolatch on JIRA:

Megan Sosey - my question was not about Open, I was aware that was RCAL's To Do status.  My question was about Done.  It is potentially an artifact of moving the work from one Epic to another, but I can't figure out how.  The items that I have identified are RCAL-113, 43, 129, 45, 111, 46 (plus this one).  Stacy (Anastasia) Smith is prepared to move them out of Resolved=Done if you approve.  

@stscijgbot-rstdms
Copy link
Collaborator Author

Comment by Megan Sosey on JIRA:

Erica Kolatch my answer included the issue with "Done", david has already started addressing the tickets in these stages, Stacy (Anastasia) Smith I wouldn't do anything without contacting him first. It is not an artifact of moving them, they were like that before I made the new epic last week.

@stscijgbot-rstdms
Copy link
Collaborator Author

Comment by Erica Kolatch on JIRA:

Megan Sosey - actually I noticed these tickets because they went to Done on the 21st of May (check the history for confirmation).  It appeared to me that you made a small change and the Resolution "came along for the ride" and was not at all intention.  

@ddavis-stsci ddavis-stsci modified the milestones: Build 0.3, Build 0.4 Sep 17, 2021
@ddavis-stsci ddavis-stsci modified the milestones: Build 0.4, Build 0.5 Dec 20, 2021
@ddavis-stsci ddavis-stsci modified the milestones: Build 0.5, Build 0.6 Jan 12, 2022
@PaulHuwe PaulHuwe mentioned this issue Mar 31, 2022
Merged
5 tasks
@stscijgbot-rstdms
Copy link
Collaborator Author

Comment by Paul Huwe on JIRA:

This is implemented in RCAL PR-469: #469

I updated the story points to reflect the work done - this work also includes the unit tests (mentioned in RCAL-113). 

@nden nden closed this as completed in #469 Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Photom team_periwinkle
Projects
None yet
Milestone
Build 0.6 (22Q3_B6)
Development

Successfully merging a pull request may close this issue.

RCAL-112: Update photom step for WFI data PaulHuwe/romancal
3 participants
@dmggh @ddavis-stsci @stscijgbot-rstdms