Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RCAL-112: Update photom step for WFI data #469

Merged
merged 12 commits into from
Apr 15, 2022

Conversation

PaulHuwe
Copy link
Collaborator

GitHub issue, Closes #152 and #153

Resolves RCAL-112

Description

This PR added photom correction step and unit tests.

Checklist

  • Tests

  • Documentation

  • Change log

  • Milestone

  • Label(s)

@PaulHuwe
Copy link
Collaborator Author

Note, this PR requires the RAD PR 132 and the RDM PR 72 for tests to pass.

@PaulHuwe
Copy link
Collaborator Author

RAD & RDM tickets are merged.

@codecov
Copy link

codecov bot commented Mar 31, 2022

Codecov Report

Merging #469 (957f5eb) into main (190ca1a) will decrease coverage by 0.04%.
The diff coverage is 70.00%.

@@            Coverage Diff             @@
##             main     #469      +/-   ##
==========================================
- Coverage   77.46%   77.41%   -0.05%     
==========================================
  Files          36       39       +3     
  Lines         963     1054      +91     
==========================================
+ Hits          746      816      +70     
- Misses        217      238      +21     
Flag Coverage Δ *Carryforward flag
nightly 77.98% <66.66%> (+0.51%) ⬆️ Carriedforward from b6bea7a

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
romancal/lib/suffix.py 97.91% <ø> (+3.63%) ⬆️
romancal/stpipe/integration.py 100.00% <ø> (ø)
romancal/photom/photom_step.py 29.16% <29.16%> (ø)
romancal/pipeline/exposure_pipeline.py 44.11% <50.00%> (+1.26%) ⬆️
romancal/photom/__init__.py 100.00% <100.00%> (ø)
romancal/photom/photom.py 100.00% <100.00%> (ø)
romancal/step.py 100.00% <100.00%> (ø)
romancal/regtest/regtestdata.py 57.14% <0.00%> (+2.55%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 190ca1a...957f5eb. Read the comment docs.

@PaulHuwe
Copy link
Collaborator Author

Checks are passing, and this is ready for review. @ddavis-stsci @nden @cshanahan1

Copy link
Collaborator

@ddavis-stsci ddavis-stsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor quibbles but overall looks good.

Copy link
Collaborator

@cshanahan1 cshanahan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just made some minor suggestions

@nden
Copy link
Collaborator

nden commented Apr 8, 2022

Are the JWST files necessary?

@PaulHuwe
Copy link
Collaborator Author

PaulHuwe commented Apr 8, 2022

Are the JWST files necessary?

Oh my.. I don't know how those got in there. I will remove them.

@PaulHuwe
Copy link
Collaborator Author

PaulHuwe commented Apr 8, 2022

The failures here appear to be due to the two outstanding RDM tickets not being merged yet.

Copy link
Collaborator

@ddavis-stsci ddavis-stsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Collaborator

@cshanahan1 cshanahan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm thought i added a review already but i guess it was just comments? lgtm now

@PaulHuwe PaulHuwe requested a review from nden April 13, 2022 20:02
@PaulHuwe PaulHuwe requested a review from nden April 15, 2022 15:20
@nden nden merged commit 5532653 into spacetelescope:main Apr 15, 2022
@PaulHuwe PaulHuwe deleted the RCAL-112_Photom branch April 15, 2022 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update photom step for WFI data
4 participants