-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RCAL-112: Update photom step for WFI data #469
Conversation
Note, this PR requires the RAD PR 132 and the RDM PR 72 for tests to pass. |
RAD & RDM tickets are merged. |
Codecov Report
@@ Coverage Diff @@
## main #469 +/- ##
==========================================
- Coverage 77.46% 77.41% -0.05%
==========================================
Files 36 39 +3
Lines 963 1054 +91
==========================================
+ Hits 746 816 +70
- Misses 217 238 +21
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report at Codecov.
|
Checks are passing, and this is ready for review. @ddavis-stsci @nden @cshanahan1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of minor quibbles but overall looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, just made some minor suggestions
Are the JWST files necessary? |
Oh my.. I don't know how those got in there. I will remove them. |
The failures here appear to be due to the two outstanding RDM tickets not being merged yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm thought i added a review already but i guess it was just comments? lgtm now
GitHub issue, Closes #152 and #153
Resolves RCAL-112
Description
This PR added photom correction step and unit tests.
Checklist
Tests
Documentation
Change log
Milestone
Label(s)