Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark Unit Test Failure #934

Closed
PaulHuwe opened this issue Oct 11, 2023 · 3 comments · Fixed by #938
Closed

Dark Unit Test Failure #934

PaulHuwe opened this issue Oct 11, 2023 · 3 comments · Fixed by #938
Labels
dark team-azure

Comments

@PaulHuwe
Copy link
Collaborator

The removal of the err array is causing a dark unit test to fail. Specifically:

FAILED romancal/dark_current/tests/test_dark.py::test_dark_step_output_dark_file[WFI-WFI_IMAGE] - AttributeError: No such attribute (err) found in node

The err test lines simply need to be removed.
@stscijgbot-rstdms
Copy link
Collaborator

This issue is tracked on JIRA as RCAL-693.

@PaulHuwe PaulHuwe mentioned this issue Oct 12, 2023
Merged
6 tasks
@stscijgbot-rstdms
Copy link
Collaborator

Comment by Paul Huwe on JIRA:

This is implemented in RCAL PR-938: #938

 

@stscijgbot-rstdms
Copy link
Collaborator

Comment by Paul Huwe on JIRA:

PR approved and merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dark team-azure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

RCAL-693: Removed err array from dark tests. PaulHuwe/romancal
2 participants
@PaulHuwe @stscijgbot-rstdms