Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RCAL-693: Removed err array from dark tests. #938

Merged
merged 5 commits into from
Oct 17, 2023

Conversation

PaulHuwe
Copy link
Collaborator

Resolves RCAL-693

Closes #934

This PR removes the err array from Dark Current unit tests.

Checklist

  • added entry in CHANGES.rst under the corresponding subsection
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below. How to run regression tests on a PR

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

All modified lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

@PaulHuwe PaulHuwe marked this pull request as ready for review October 13, 2023 01:10
@PaulHuwe PaulHuwe requested a review from a team as a code owner October 13, 2023 01:10
@PaulHuwe PaulHuwe merged commit c5197ba into spacetelescope:main Oct 17, 2023
ddavis-stsci pushed a commit to ddavis-stsci/romancal that referenced this pull request Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dark Unit Test Failure
2 participants