Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

romancal.scripts.static_preview is causing downstream testing errors #976

Closed
WilliamJamieson opened this issue Nov 6, 2023 · 1 comment · Fixed by #977
Closed

romancal.scripts.static_preview is causing downstream testing errors #976

WilliamJamieson opened this issue Nov 6, 2023 · 1 comment · Fixed by #977

Comments

@WilliamJamieson
Copy link
Collaborator

The following lines are causing downstream testing errors

from typing_extensions import Annotated
try:
import typer
from stpreview.downsample import downsample_asdf_to
from stpreview.image import north_pole_angle, percentile_normalization, write_image
except (ImportError, ModuleNotFoundError):
raise ImportError(
'SDP requirements not installed; do `pip install "romancal[sdp]"`'
)

This is because typing_extensions is an external dependency which is not listed in the pyproject.toml file and stpreview is not a standard install. This occurs because when running the romacal tests relative to changes in another library, the exemption of romancal.scripts from pytest recursing in:

'romancal/scripts',

cannot be respected by a third party package executing the romancal tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant