Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protect imports in script better #977

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Protect imports in script better #977

merged 1 commit into from
Nov 7, 2023

Conversation

WilliamJamieson
Copy link
Collaborator

Resolves RCAL-nnnn

Closes #976

This PR protects the external dependencies by making them local to a function. This way they are not imported immediately.

Checklist

  • added entry in CHANGES.rst under the corresponding subsection
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below. How to run regression tests on a PR

@WilliamJamieson WilliamJamieson requested a review from a team as a code owner November 6, 2023 21:29
@codecov Codecov
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Attention: 31 lines in your changes are missing coverage. Please review.

Files Coverage Δ
romancal/scripts/static_preview.py 15.78% <6.06%> (+2.27%) ⬆️

... and 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!

zacharyburnett
zacharyburnett approved these changes Nov 7, 2023
View reviewed changes
Copy link
Collaborator

@zacharyburnett zacharyburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! I didn't think to just put the other functions in the main function itself

@zacharyburnett zacharyburnett merged commit a3d160f into spacetelescope:main Nov 7, 2023
@zacharyburnett zacharyburnett mentioned this pull request Nov 8, 2023
Merged
6 tasks
@WilliamJamieson WilliamJamieson deleted the bugfix/scripts branch November 22, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zacharyburnett zacharyburnett zacharyburnett approved these changes

Assignees
No one assigned
Labels
no-changelog-entry-needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

romancal.scripts.static_preview is causing downstream testing errors
2 participants
@WilliamJamieson @zacharyburnett