-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update resample test to use new files. #1009
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I added the no-change-log-needed label.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1009 +/- ##
=======================================
Coverage 73.32% 73.32%
=======================================
Files 103 103
Lines 6733 6733
=======================================
Hits 4937 4937
Misses 1796 1796
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This PR addresses updates the resample regression test to use file names from the newest set of files. It also takes advantage of the asn_from_list module to jettison some home-made asn-making code.