Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update resample test to use new files. #1009

Merged
merged 7 commits into from
Nov 17, 2023

Conversation

schlafly
Copy link
Collaborator

This PR addresses updates the resample regression test to use file names from the newest set of files. It also takes advantage of the asn_from_list module to jettison some home-made asn-making code.

@schlafly schlafly requested a review from a team as a code owner November 17, 2023 15:41
Copy link
Collaborator

@ddavis-stsci ddavis-stsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I added the no-change-log-needed label.

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (09e040a) 73.32% compared to head (07f5492) 73.32%.
Report is 1 commits behind head on main.

❗ Current head 07f5492 differs from pull request most recent head 7e33b40. Consider uploading reports for the commit 7e33b40 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1009   +/-   ##
=======================================
  Coverage   73.32%   73.32%           
=======================================
  Files         103      103           
  Lines        6733     6733           
=======================================
  Hits         4937     4937           
  Misses       1796     1796           
Flag Coverage Δ *Carryforward flag
nightly 63.29% <ø> (ø) Carriedforward from e803d5e

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@schlafly schlafly merged commit 79586ea into spacetelescope:main Nov 17, 2023
@schlafly schlafly deleted the update-resample-test branch November 17, 2023 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants