Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rcal-457 Add test for spectral preview files #1021

Merged
merged 7 commits into from
Nov 21, 2023

Conversation

ddavis-stsci
Copy link
Collaborator

@ddavis-stsci ddavis-stsci commented Nov 21, 2023

Resolves RCAL-nnnn

Closes #

This PR adds a check for the preview file that needs to be generated for DMS278 (https://jira.stsci.edu/projects/RDM/issues/RDM-3153) and for imaging previews DMS281 (https://jira.stsci.edu/browse/RDM-3152)

Checklist

  • [N/A] added entry in CHANGES.rst under the corresponding subsection
  • updated relevant tests
  • [N/A] updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below. How to run regression tests on a PR

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ba515d9) 71.07% compared to head (a7b44d3) 71.21%.
Report is 1 commits behind head on main.

❗ Current head a7b44d3 differs from pull request most recent head cd55252. Consider uploading reports for the commit cd55252 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1021      +/-   ##
==========================================
+ Coverage   71.07%   71.21%   +0.14%     
==========================================
  Files         104      104              
  Lines        7005     7008       +3     
==========================================
+ Hits         4979     4991      +12     
+ Misses       2026     2017       -9     
Flag Coverage Δ *Carryforward flag
nightly 63.29% <ø> (ø) Carriedforward from 2f545d8

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ddavis-stsci ddavis-stsci merged commit d8bda78 into spacetelescope:main Nov 21, 2023
@ddavis-stsci ddavis-stsci deleted the rcal-457_spec_preview branch November 21, 2023 16:14
stscieisenhamer pushed a commit to stscieisenhamer/romancal that referenced this pull request Nov 21, 2023
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants