Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add documentation for static preview script #1046

Merged
merged 11 commits into from
Dec 11, 2023
Merged

add documentation for static preview script #1046

merged 11 commits into from
Dec 11, 2023

Conversation

zacharyburnett
Copy link
Collaborator

Resolves RCAL-731

This PR adds documentation for roman_static_preview

Checklist

  • added entry in CHANGES.rst under the corresponding subsection
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below. How to run regression tests on a PR

@zacharyburnett zacharyburnett self-assigned this Dec 11, 2023
@github-actions github-actions bot added documentation Improvements or additions to documentation pipeline labels Dec 11, 2023
@zacharyburnett
Copy link
Collaborator Author

page hosted at https://roman-pipeline--1046.org.readthedocs.build/en/1046/roman/pipeline_static_preview.html

@codecov Codecov
Copy link

codecov bot commented Dec 11, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (afbf5c1) 70.94% compared to head (b41ac1f) 70.94%.

❗ Current head b41ac1f differs from pull request most recent head ddd71f1. Consider uploading reports for the commit ddd71f1 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1046   +/-   ##
=======================================
  Coverage   70.94%   70.94%           
=======================================
  Files         105      105           
  Lines        6979     6981    +2     
=======================================
+ Hits         4951     4953    +2     
  Misses       2028     2028
Flag Coverage Δ *Carryforward flag
nightly 63.06% <ø> (ø) Carriedforward from c1bdb80

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zacharyburnett
Copy link
Collaborator Author

zacharyburnett commented Dec 11, 2023 •
edited
Loading

the images aren't showing:
image

EDIT: fixed by checking out Git LFS objects

@zacharyburnett zacharyburnett marked this pull request as ready for review December 11, 2023 18:31
@zacharyburnett zacharyburnett requested a review from a team as a code owner December 11, 2023 18:31
ddavis-stsci
ddavis-stsci approved these changes Dec 11, 2023
View reviewed changes
Copy link
Collaborator

@ddavis-stsci ddavis-stsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments but overall it looks good.

@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Dec 11, 2023
@github-actions github-actions bot removed the dependencies Pull requests that update a dependency file label Dec 11, 2023
@zacharyburnett zacharyburnett merged commit 1a458a0 into spacetelescope:main Dec 11, 2023
@zacharyburnett zacharyburnett deleted the docs/static_preview branch December 11, 2023 19:34
@stscijgbot-rstdms stscijgbot-rstdms mentioned this pull request Dec 12, 2023
Closed
ddavis-stsci pushed a commit to ddavis-stsci/romancal that referenced this pull request Dec 12, 2023
@zacharyburnett @ddavis-stsci
add documentation for static preview script (spacetelescope#1046)
d28e6e7
ddavis-stsci pushed a commit to ddavis-stsci/romancal that referenced this pull request Dec 15, 2023
@zacharyburnett @ddavis-stsci
add documentation for static preview script (spacetelescope#1046)
138c372
@zacharyburnett zacharyburnett mentioned this pull request Dec 15, 2023
Closed
6 tasks
ddavis-stsci pushed a commit to ddavis-stsci/romancal that referenced this pull request Dec 19, 2023
@zacharyburnett @ddavis-stsci
add documentation for static preview script (spacetelescope#1046)
04d797b
ddavis-stsci pushed a commit to ddavis-stsci/romancal that referenced this pull request Dec 19, 2023
@zacharyburnett @ddavis-stsci
add documentation for static preview script (spacetelescope#1046)
247cd99
ddavis-stsci pushed a commit to ddavis-stsci/romancal that referenced this pull request Dec 20, 2023
@zacharyburnett @ddavis-stsci
add documentation for static preview script (spacetelescope#1046)
b0734cc
ddavis-stsci pushed a commit to ddavis-stsci/romancal that referenced this pull request Jan 11, 2024
@zacharyburnett @ddavis-stsci
add documentation for static preview script (spacetelescope#1046)
a5c6bf3
ddavis-stsci pushed a commit to ddavis-stsci/romancal that referenced this pull request Jan 12, 2024
@zacharyburnett @ddavis-stsci
add documentation for static preview script (spacetelescope#1046)
3ef4dac
ddavis-stsci pushed a commit to ddavis-stsci/romancal that referenced this pull request Jan 17, 2024
@zacharyburnett @ddavis-stsci
add documentation for static preview script (spacetelescope#1046)
a645001
ddavis-stsci pushed a commit to ddavis-stsci/romancal that referenced this pull request Jan 17, 2024
@zacharyburnett @ddavis-stsci
add documentation for static preview script (spacetelescope#1046)
ebae271
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddavis-stsci ddavis-stsci ddavis-stsci approved these changes

Assignees

@zacharyburnett zacharyburnett

Labels
associations documentation Improvements or additions to documentation pipeline
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zacharyburnett @ddavis-stsci