Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a default WCS for ramp fitting. #1072

Merged
merged 2 commits into from
Jan 26, 2024

Conversation

schlafly
Copy link
Collaborator

@schlafly schlafly commented Jan 25, 2024

Units test started failing when we made the WCS a required argument, because the unit tests relied on being able to construct ImageModels from default RampModels. The latter don't have default WCSes, but the former require them, so the code to construct the one from the other needs to add a default WCS.

Checklist

  • added entry in CHANGES.rst under the corresponding subsection
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below. How to run regression tests on a PR

@schlafly schlafly added the bug Something isn't working label Jan 25, 2024
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.74%. Comparing base (1dc0501) to head (f91a3ff).
Report is 443 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1072   +/-   ##
=======================================
  Coverage   76.74%   76.74%           
=======================================
  Files         105      105           
  Lines        7013     7013           
=======================================
  Hits         5382     5382           
  Misses       1631     1631           
Flag Coverage Δ *Carryforward flag
nightly 63.01% <ø> (-0.02%) ⬇️ Carriedforward from 39a4d7e

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@nden nden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will do it.

@schlafly schlafly marked this pull request as ready for review January 26, 2024 14:44
@schlafly schlafly requested a review from a team as a code owner January 26, 2024 14:44
@schlafly schlafly merged commit c3a7025 into spacetelescope:main Jan 26, 2024
30 checks passed
@schlafly schlafly deleted the add-default-wcs-to-image-model branch January 26, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ramp_fitting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants