Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update actions version #1096

Merged
merged 2 commits into from
May 9, 2024
Merged

update actions version #1096

merged 2 commits into from
May 9, 2024

Conversation

zacharyburnett
Copy link
Collaborator

Resolves SCSB-139

Checklist

  • added entry in CHANGES.rst under the corresponding subsection
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below. How to run regression tests on a PR

@zacharyburnett zacharyburnett self-assigned this Feb 8, 2024
@codecov Codecov
Copy link

codecov bot commented May 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.93%. Comparing base (2a4a78d) to head (83879a5).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1096   +/-   ##
=======================================
  Coverage   78.93%   78.93%           
=======================================
  Files         117      117           
  Lines        8086     8086           
=======================================
  Hits         6383     6383           
  Misses       1703     1703
Flag Coverage Δ *Carryforward flag
nightly 62.78% <ø> (ø) Carriedforward from 2a4a78d

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zacharyburnett zacharyburnett marked this pull request as ready for review May 9, 2024 11:35
@zacharyburnett zacharyburnett requested a review from a team as a code owner May 9, 2024 11:35
braingram
braingram approved these changes May 9, 2024
View reviewed changes
Copy link
Collaborator

@braingram braingram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

schlafly
schlafly approved these changes May 9, 2024
View reviewed changes
Copy link
Collaborator

@schlafly schlafly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@zacharyburnett zacharyburnett merged commit d27f0d4 into spacetelescope:main May 9, 2024
30 checks passed
@zacharyburnett zacharyburnett deleted the update/actions branch May 9, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@braingram braingram braingram approved these changes

@schlafly schlafly schlafly approved these changes

Assignees

@zacharyburnett zacharyburnett

Labels
automation no-changelog-entry-needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zacharyburnett @braingram @schlafly