Make copies of border pixel arrays when building L2 image. #1098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1098 +/- ##
=======================================
Coverage 76.81% 76.81%
=======================================
Files 105 105
Lines 7048 7048
=======================================
Hits 5414 5414
Misses 1634 1634
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@ddavis-stsci , we could conceivably include this. This makes the L2 files we make 3x smaller but doesn't affect any regression tests in my run. It addresses @wlim-ipac 's issue from the call yesterday. |
ddavis-stsci
approved these changes
Feb 9, 2024
WilliamJamieson
approved these changes
Feb 9, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
romancal produces larger L2 files than one would expect given the sizes of the arrays in rad; typical L2 file sizes are ~1.1 GB but one would estimate ~400 MB from the different planes. The issue turns out to be that the border pixels are views into the larger full L1 image rather than copies just of the side 4 pixels. asdf is saving the full array, rather than just the small subset representing the view, leading to the large files.
Changing these to copies addresses the issue. After this change, file sizes reduce to ~400 MB.
Checklist