Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove link to non-existent STScI logo #1186

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

larrybradley
Copy link
Member

The stsci_logo.png does not exist in docs/_static. It looks like this line was copied from thejwst readme, but the logo was not.

Checklist

  • added entry in CHANGES.rst under the corresponding subsection
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below. How to run regression tests on a PR

@larrybradley larrybradley requested a review from a team as a code owner April 17, 2024 20:31
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Apr 17, 2024
@larrybradley
Copy link
Member Author

I don't have permissions to add labels or milestones. @nden

@schlafly
Copy link
Collaborator

Looks good to me. A related option would be to change it to the Roman logo, which we do have in docs/_static.
roman_logo_black_w200px.png

Copy link

codecov bot commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.15%. Comparing base (902c5f8) to head (2df177e).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1186      +/-   ##
==========================================
+ Coverage   76.76%   77.15%   +0.39%     
==========================================
  Files         107      107              
  Lines        7096     7101       +5     
==========================================
+ Hits         5447     5479      +32     
+ Misses       1649     1622      -27     
Flag Coverage Δ *Carryforward flag
nightly 62.80% <ø> (ø) Carriedforward from 902c5f8

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nden
Copy link
Collaborator

nden commented Apr 17, 2024

@larrybradley permissions fixed

@larrybradley
Copy link
Member Author

larrybradley commented Apr 18, 2024

@schlafly The Roman logos in docs/_static both have transparent backgrounds and are black or white. The black logo will be invisible for users using GitHub dark mode and vice versa for the white logo with light mode. We'd need a non-transparent background or a logo color other than black or white.

@schlafly schlafly merged commit 8a86f8f into spacetelescope:main Apr 18, 2024
36 of 37 checks passed
@larrybradley larrybradley deleted the fix-readme branch April 18, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation no-changelog-entry-needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants