Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix finalize #1201

Merged
merged 5 commits into from
Apr 26, 2024
Merged

Fix finalize #1201

merged 5 commits into from
Apr 26, 2024

Conversation

nden
Copy link
Collaborator

@nden nden commented Apr 26, 2024

Part of RCAL-823

Closes #

This PR addresses ...

Checklist

  • added entry in CHANGES.rst under the corresponding subsection
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below. How to run regression tests on a PR

Passing regression tests
https://plwishmaster.stsci.edu:8081/job/RT/job/Roman-Developers-Pull-Requests/720/

@nden nden requested a review from a team as a code owner April 26, 2024 16:43
@larrybradley larrybradley mentioned this pull request Apr 26, 2024
6 tasks
Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.36%. Comparing base (2df177e) to head (7e531c0).
Report is 6 commits behind head on main.

❗ Current head 7e531c0 differs from pull request most recent head 5ba6e2f. Consider uploading reports for the commit 5ba6e2f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1201      +/-   ##
==========================================
+ Coverage   77.15%   77.36%   +0.20%     
==========================================
  Files         107      109       +2     
  Lines        7101     7295     +194     
==========================================
+ Hits         5479     5644     +165     
- Misses       1622     1651      +29     
Flag Coverage Δ *Carryforward flag
nightly 62.80% <ø> (ø) Carriedforward from 2df177e

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nden nden requested a review from larrybradley April 26, 2024 17:03
Copy link
Member

@larrybradley larrybradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @nden! This fixes the issues I was having with #1102.

@nden nden added this to the 24Q3_B14 milestone Apr 26, 2024
@nden nden merged commit 7871ce1 into spacetelescope:main Apr 26, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants