RCAL-828: add PSF bits to source catalog. #1243

mairanteodoro · 2024-05-17T19:36:16Z

This PR addresses the implementation of PSF photometry into SourceCatalogStep.

Regression Tests
Regression tests are all passing.
~~https://plwishmaster.stsci.edu:8081/job/RT/job/Roman-Developers-Pull-Requests/775/~~
~~https://plwishmaster.stsci.edu:8081/job/RT/job/Roman-Developers-Pull-Requests/798/~~
~~https://plwishmaster.stsci.edu:8081/job/RT/job/Roman-Developers-Pull-Requests/808/~~
~~https://plwishmaster.stsci.edu:8081/job/RT/job/Roman-Developers-Pull-Requests/809/~~
https://plwishmaster.stsci.edu:8081/job/RT/job/Roman-Developers-Pull-Requests/814/

Checklist

added entry in CHANGES.rst under the corresponding subsection
updated relevant tests
updated relevant documentation
updated relevant milestone(s)
added relevant label(s)
ran regression tests, post a link to the Jenkins job below. How to run regression tests on a PR

…ce_catalog

for more information, see https://pre-commit.ci

codecov · 2024-05-17T20:05:34Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.99%. Comparing base (9662356) to head (87dd5e5).
Report is 192 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1243      +/-   ##
==========================================
+ Coverage   78.87%   78.99%   +0.11%     
==========================================
  Files         117      117              
  Lines        8071     8101      +30     
==========================================
+ Hits         6366     6399      +33     
+ Misses       1705     1702       -3

Flag	Coverage Δ		*Carryforward flag
nightly	`62.79% <ø> (ø)`		Carriedforward from 9662356

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

schlafly

This looks good to me. Let's make sure it runs for both L2 and L3 products; I suspect it will not at the moment.. Can you compare a source_detection catalog with a source_catalog PSF catalog and see how similar they are? We want the positions to be ~the same at the ~0.01 pix level.

romancal/source_catalog/source_catalog.py

romancal/source_catalog/source_catalog_step.py

romancal/source_catalog/source_catalog.py

…pe#1249) I'm assuming the comment above from ES is intended to be an approval

mairanteodoro · 2024-05-30T19:24:51Z

Comparison between the results from source_detection and source_catalog (for all plots, the vertical and horizontal lines correspond to the range between -0.01 and +0.01 pix):

Comparison between the results from source_detection and the "truth" coordinates used in romanisim for source injection:

Comparison between the results from source_catalog and the "truth" coordinates used in romanisim for source injection:

for more information, see https://pre-commit.ci

schlafly

This looks good to me, thanks. I left one inline comment.

romancal/source_catalog/source_catalog.py

for more information, see https://pre-commit.ci

Co-authored-by: zacharyburnett <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Brett <[email protected]> Co-authored-by: D Davis <[email protected]>

mairanteodoro and others added 7 commits May 15, 2024 13:50

Implement PSF photometry into SourceCatalogStep.

abedbba

Small refactoring to improve code readability.

866aa9a

Unit tests small refactoring.

7471ebf

freeze change log for release

c8b944f

update software build table with newest releases

b208f16

Refactor unit test and add a new one.

d646dab

Merge branch 'spacetelescope:main' into RCAL-828-add-psf-bits-to-sour…

882f0c7

…ce_catalog

mairanteodoro added the no-changelog-entry-needed label May 17, 2024

github-actions bot added the testing label May 17, 2024

pre-commit-ci bot and others added 2 commits May 17, 2024 19:36

[pre-commit.ci] auto fixes from pre-commit.com hooks

e764674

for more information, see https://pre-commit.ci

Add changelog entry.

b0d37e8

mairanteodoro removed the no-changelog-entry-needed label May 17, 2024

mairanteodoro changed the title ~~Rcal 828 add psf bits to source catalog~~ RCAL-828: add PSF bits to source catalog. May 17, 2024

stscijgbot-rstdms mentioned this pull request May 17, 2024

Add PSF bits to source_catalog #1219

Closed

schlafly reviewed May 21, 2024

View reviewed changes

romancal/source_catalog/source_catalog.py Outdated Show resolved Hide resolved

romancal/source_catalog/source_catalog_step.py Outdated Show resolved Hide resolved

romancal/source_catalog/source_catalog.py Outdated Show resolved Hide resolved

braingram and others added 3 commits May 28, 2024 09:53

remove clean_up_after_test

59e5fc1

rcal-845_dsd rename highlevelpipeline to mosaicpipeline (spacetelesco…

5024311

…pe#1249) I'm assuming the comment above from ES is intended to be an approval

Update python from 3.9 to 310 in JenkinsfileRT_dev (spacetelescope#1251)

6658093

github-actions bot added documentation Improvements or additions to documentation pipeline stpipe regression_testing automation labels May 28, 2024

Merge branch 'main' into RCAL-828-add-psf-bits-to-source_catalog

f08944e

github-actions bot removed documentation Improvements or additions to documentation pipeline stpipe regression_testing automation labels May 28, 2024

Merge branch 'main' into RCAL-828-add-psf-bits-to-source_catalog

bed7d45

mairanteodoro marked this pull request as ready for review May 30, 2024 19:53

mairanteodoro requested a review from a team as a code owner May 30, 2024 19:53

mairanteodoro and others added 4 commits May 30, 2024 16:17

Handle initialization of DQ mask for L3 files.

135ad75

Proper extraction of metadata for L3 files.

3c2e053

Refactor unit tests to prevent polution of local folder.

9a2c569

[pre-commit.ci] auto fixes from pre-commit.com hooks

5741da4

for more information, see https://pre-commit.ci

mairanteodoro requested a review from schlafly May 30, 2024 21:05

mairanteodoro added 5 commits May 30, 2024 17:12

Fix style check issues.

9844e42

Remove PSF lib content from source_detection to prevent duplication.

ddb02b0

Fix column names for PSF method.

5233f6c

Update source_catalog docs.

6a3f4d9

Fix style checks.

d3377f5

github-actions bot added the documentation Improvements or additions to documentation label May 31, 2024

mairanteodoro added 3 commits June 4, 2024 15:22

Fix issue with NaN values and coordinates convention.

ba2d457

Merge branch 'main' into RCAL-828-add-psf-bits-to-source_catalog

085afe5

Fix issue with weight array in mock datamodel.

80ed697

schlafly reviewed Jun 6, 2024

View reviewed changes

romancal/source_catalog/source_catalog.py Show resolved Hide resolved

mairanteodoro and others added 3 commits June 6, 2024 16:20

Merge branch 'main' into RCAL-828-add-psf-bits-to-source_catalog

d7ac676

Clean up after PSF photometry.

dfeef4c

[pre-commit.ci] auto fixes from pre-commit.com hooks

76220d5

for more information, see https://pre-commit.ci

schlafly approved these changes Jun 6, 2024

View reviewed changes

mairanteodoro added 4 commits June 6, 2024 20:28

Fix bug when setting meta.background in SkyMatchStep.

f3b1c11

Add changelog entry.

9cca67b

Fix assertion operator.

1474759

Merge branch 'main' into RCAL-828-add-psf-bits-to-source_catalog

87dd5e5

mairanteodoro merged commit f22e4b9 into spacetelescope:main Jun 7, 2024
30 checks passed

nden added this to the 24Q4_B15 milestone Jul 19, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RCAL-828: add PSF bits to source catalog. #1243

RCAL-828: add PSF bits to source catalog. #1243

mairanteodoro commented May 17, 2024 •

edited

Loading

codecov bot commented May 17, 2024 •

edited

Loading

schlafly left a comment

mairanteodoro commented May 30, 2024 •

edited

Loading

schlafly left a comment

RCAL-828: add PSF bits to source catalog. #1243

RCAL-828: add PSF bits to source catalog. #1243

Conversation

mairanteodoro commented May 17, 2024 • edited Loading

codecov bot commented May 17, 2024 • edited Loading

Codecov Report

schlafly left a comment

Choose a reason for hiding this comment

mairanteodoro commented May 30, 2024 • edited Loading

schlafly left a comment

Choose a reason for hiding this comment

mairanteodoro commented May 17, 2024 •

edited

Loading

codecov bot commented May 17, 2024 •

edited

Loading

mairanteodoro commented May 30, 2024 •

edited

Loading