Refactor DQInitStep to use the RampModel method of creating ramps #1258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1258 +/- ##
==========================================
- Coverage 78.93% 78.92% -0.02%
==========================================
Files 117 117
Lines 8086 8065 -21
==========================================
- Hits 6383 6365 -18
+ Misses 1703 1700 -3
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
stscieisenhamer
force-pushed
the
rcal-833-tvac
branch
from
1adc018 to
c4ed963
Compare
|
CI failures due to not having the updated RDM pr 352 merged. |
github-actions
bot
added
the
dependencies
|
Regression try #2 to confirm pyproject changes: Success. |
zacharyburnett
pushed a commit
to zacharyburnett/romancal
that referenced
this pull request
Jul 22, 2024
…acetelescope#1258) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves RCAL-833
Related PRs
This PR addresses an issue discovered while trying to run the pipeline on TVAC data where tags were not being converted appropriately. This was occurring in the DQInitStep with dedicated code for the meta copying. In conjuction with the RDM PR, the meta copy is fixed.
Checklist
CHANGES.rstunder the corresponding subsection