-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rcal-846 Add mosaic info to the science products RTD page #1262
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1262 +/- ##
==========================================
- Coverage 78.93% 78.85% -0.09%
==========================================
Files 117 117
Lines 8086 8088 +2
==========================================
- Hits 6383 6378 -5
- Misses 1703 1710 +7
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, though I left a comment inline with some questions about some of the fields in the i2d files...
| var_rnoise | Required | float32 | (e\ :sup:`-`/ s)\ :sup:`2`| nrows x ncols | | ||
+----------------------+----------+------------+---------------------------+-------------------------------+ | ||
| var_flat | Required | float32 | (e\ :sup:`-`/ s)\ :sup:`2`| nrows x ncols | | ||
+----------------------+----------+------------+---------------------------+-------------------------------+ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you check the units here? The flux calibration step is supposed to make sure the units are MJy/sr (or the square of that for the variances), but we may have errors, of course. I had understood the context image to be N x nrows x ncols, where N depends on the number of input images, and is 1 for sky cells with fewer than 32 input images. Not true?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I must have looked at an old file. I've updated the units.
for the number of planes in the context image I thought as you said, it should be the number of input images modulo 32. In the output I see
context (NDArrayType): shape=(2, 9191, 8642), dtype=uint32 # Context Data
The number of input images was 8 (not all overlapping).
Maybe a bug?
Was this the number of input SCAs or exposures? If the latter, maybe the number of SCAs is >32, and this is the fact that we're not grouping? But yeah, I suspect a bug of some kind. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird, thanks. Let's file a ticket to investigate the number of planes to expect, but looks good to me.
Resolves RCAL-846
Closes #1252
This PR adds a description of the i2d (mosaic) data to read-the-docs.
Checklist
CHANGES.rst
under the corresponding subsection