Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rcal-846 Add mosaic info to the science products RTD page #1262

Merged
merged 5 commits into from
Jun 4, 2024

Conversation

ddavis-stsci
Copy link
Collaborator

Resolves RCAL-846

Closes #1252

This PR adds a description of the i2d (mosaic) data to read-the-docs.

Checklist

  • added entry in CHANGES.rst under the corresponding subsection
  • [N/A] updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)
  • [N/A] ran regression tests, post a link to the Jenkins job below. How to run regression tests on a PR

@ddavis-stsci ddavis-stsci added the documentation Improvements or additions to documentation label Jun 3, 2024
@ddavis-stsci ddavis-stsci added this to the 24Q4_B15 milestone Jun 3, 2024
@ddavis-stsci ddavis-stsci self-assigned this Jun 3, 2024
@ddavis-stsci ddavis-stsci marked this pull request as ready for review June 3, 2024 20:03
@ddavis-stsci ddavis-stsci requested a review from a team as a code owner June 3, 2024 20:03
Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.85%. Comparing base (1aec135) to head (51ba23b).
Report is 5 commits behind head on main.

Current head 51ba23b differs from pull request most recent head 7bf99f1

Please upload reports for the commit 7bf99f1 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1262      +/-   ##
==========================================
- Coverage   78.93%   78.85%   -0.09%     
==========================================
  Files         117      117              
  Lines        8086     8088       +2     
==========================================
- Hits         6383     6378       -5     
- Misses       1703     1710       +7     
Flag Coverage Δ *Carryforward flag
nightly 62.84% <ø> (+0.06%) ⬆️ Carriedforward from 1aec135

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@schlafly schlafly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, though I left a comment inline with some questions about some of the fields in the i2d files...

| var_rnoise | Required | float32 | (e\ :sup:`-`/ s)\ :sup:`2`| nrows x ncols |
+----------------------+----------+------------+---------------------------+-------------------------------+
| var_flat | Required | float32 | (e\ :sup:`-`/ s)\ :sup:`2`| nrows x ncols |
+----------------------+----------+------------+---------------------------+-------------------------------+
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you check the units here? The flux calibration step is supposed to make sure the units are MJy/sr (or the square of that for the variances), but we may have errors, of course. I had understood the context image to be N x nrows x ncols, where N depends on the number of input images, and is 1 for sky cells with fewer than 32 input images. Not true?

Copy link
Collaborator Author

@ddavis-stsci ddavis-stsci Jun 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I must have looked at an old file. I've updated the units.

for the number of planes in the context image I thought as you said, it should be the number of input images modulo 32. In the output I see
context (NDArrayType): shape=(2, 9191, 8642), dtype=uint32 # Context Data
The number of input images was 8 (not all overlapping).
Maybe a bug?

@schlafly
Copy link
Collaborator

schlafly commented Jun 3, 2024

Was this the number of input SCAs or exposures? If the latter, maybe the number of SCAs is >32, and this is the fact that we're not grouping? But yeah, I suspect a bug of some kind.

@ddavis-stsci
Copy link
Collaborator Author

ddavis-stsci commented Jun 4, 2024 via email

Copy link
Collaborator

@schlafly schlafly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird, thanks. Let's file a ticket to investigate the number of planes to expect, but looks good to me.

@ddavis-stsci ddavis-stsci merged commit 9216445 into spacetelescope:main Jun 4, 2024
27 of 28 checks passed
@ddavis-stsci ddavis-stsci deleted the rcal-846 branch June 4, 2024 12:51
zacharyburnett pushed a commit to zacharyburnett/romancal that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
associations documentation Improvements or additions to documentation pipeline
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add mosaic data description to RTD
2 participants