rcal-850 Addition of catalog step to mosaic pipeline #1266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schlafly
reviewed
Jun 6, 2024
| @@ -77,7 +80,8 @@ def process(self, input): | |||
| # check to see if the product name contains a skycell name & if true get the skycell record | |||
| product_name = input.asn_table["products"][0]["name"] | |||
| try: | |||
| skycell_name = product_name.split("_")[3] | |||
| skycell_name = product_name.split("_")[1] | |||
| skycell_name = input.asn_table["target"] | |||
There was a problem hiding this comment.
At present the product_name-based skycell_name is immediately overwritten by the target-based one? Probably just delete line 83 if we have updated asn files?
There was a problem hiding this comment.
And now you know why it is a draft.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1266 +/- ##
==========================================
- Coverage 78.92% 78.87% -0.05%
==========================================
Files 117 117
Lines 8065 8071 +6
==========================================
+ Hits 6365 6366 +1
- Misses 1700 1705 +5
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
github-actions
bot
added
the
documentation
for more information, see https://pre-commit.ci
zacharyburnett
pushed a commit
to zacharyburnett/romancal
that referenced
this pull request
Jul 22, 2024
…1266) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves RCAL-850
Closes #1256
This PR adds the source catalog step to run on the resampled image at the end of the mosaic pipeline to create the
_cat.asdf
_segm.asdf
files.
Checklist
CHANGES.rstunder the corresponding subsectionhttps://plwishmaster.stsci.edu:8081/job/RT/job/Roman-Developers-Pull-Requests/813/