Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rcal-859 Update okify script to use GA directories on artifactory #1282

Merged
merged 5 commits into from
Jun 25, 2024

Conversation

ddavis-stsci
Copy link
Collaborator

Resolves RCAL-859

Closes #1281

This PR updates the okify script to use the GA directories in artifactory.

Checklist

  • added entry in CHANGES.rst under the corresponding subsection
  • [N/A] updated relevant tests
  • [N/A] updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)
  • [N/a] ran regression tests, post a link to the Jenkins job below. How to run regression tests on a PR

@ddavis-stsci ddavis-stsci self-assigned this Jun 18, 2024
@ddavis-stsci ddavis-stsci requested a review from a team as a code owner June 18, 2024 18:55
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 79.39%. Comparing base (0ad965c) to head (8cb33a1).
Report is 188 commits behind head on main.

Files with missing lines Patch % Lines
romancal/scripts/okify_regtests.py 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1282      +/-   ##
==========================================
+ Coverage   79.36%   79.39%   +0.02%     
==========================================
  Files         117      117              
  Lines        8079     8076       -3     
==========================================
  Hits         6412     6412              
+ Misses       1667     1664       -3     
Flag Coverage Δ *Carryforward flag
nightly 62.84% <ø> (+0.06%) ⬆️ Carriedforward from 0ad965c

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ddavis-stsci ddavis-stsci merged commit 7ae6c53 into spacetelescope:main Jun 25, 2024
29 of 30 checks passed
@ddavis-stsci ddavis-stsci deleted the rcal-859 branch June 25, 2024 12:15
zacharyburnett pushed a commit to zacharyburnett/romancal that referenced this pull request Jul 22, 2024
…acetelescope#1282)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update okify script for GA
1 participant