Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rcal 860 Allow roman datamodel as input to the exposure pipeline #1296

Merged
merged 9 commits into from
Jul 8, 2024

Conversation

ddavis-stsci
Copy link
Collaborator

Resolves RCAL-860

Closes #1284

This PR allows the exposure pipeline to accept a roman datamodel as an input.

Checklist

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

Attention: Patch coverage is 30.43478% with 16 lines in your changes missing coverage. Please review.

Project coverage is 79.37%. Comparing base (74a137c) to head (b6290fb).
Report is 233 commits behind head on main.

Files with missing lines Patch % Lines
romancal/pipeline/exposure_pipeline.py 0.00% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1296      +/-   ##
==========================================
- Coverage   79.39%   79.37%   -0.03%     
==========================================
  Files         117      117              
  Lines        8076     8086      +10     
==========================================
+ Hits         6412     6418       +6     
- Misses       1664     1668       +4     
Flag Coverage Δ *Carryforward flag
nightly 62.84% <ø> (ø) Carriedforward from 74a137c

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@schlafly schlafly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@ddavis-stsci ddavis-stsci merged commit 8a7f497 into spacetelescope:main Jul 8, 2024
29 of 30 checks passed
@ddavis-stsci ddavis-stsci deleted the rcal-860 branch July 8, 2024 19:25
zacharyburnett pushed a commit to zacharyburnett/romancal that referenced this pull request Jul 22, 2024
…cetelescope#1296)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow the exposure pipeline to accept a datamodel as input
2 participants