Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue in constructing skycell WCS. #1297

Merged
merged 5 commits into from
Jul 9, 2024

Conversation

schlafly
Copy link
Collaborator

@schlafly schlafly commented Jul 8, 2024

This PR fixes some issues in the of the skycell WCS.

Formerly, the code used the center pixel of the WCS to mark the edge of the bounding box. That meant that the bounding box only covered a quarter of the image, leading to issues.

The "shift" used to move from the projection center was also using the edge of the bounding box. We now use the projection center in x/y coordinates.

This is intended to address an issue that @snbianco raised. I've placed a new example L3 image at
/grp/roman/eschlafly/misc/r0099101001001001001_F158_visit_r274dp63x31y81_i2d.asdf
that should have this issue fixed, but please check!

@schlafly schlafly requested a review from a team as a code owner July 8, 2024 17:00
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 79.37%. Comparing base (8a7f497) to head (dedc0cc).
Report is 232 commits behind head on main.

Files with missing lines Patch % Lines
romancal/pipeline/mosaic_pipeline.py 20.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1297   +/-   ##
=======================================
  Coverage   79.37%   79.37%           
=======================================
  Files         117      117           
  Lines        8086     8086           
=======================================
  Hits         6418     6418           
  Misses       1668     1668           
Flag Coverage Δ *Carryforward flag
nightly 62.84% <ø> (ø) Carriedforward from 55eed26

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ddavis-stsci ddavis-stsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snbianco
Copy link

snbianco commented Jul 9, 2024

This resolves the problem I was running into, thank you!

@schlafly schlafly merged commit a287ea1 into spacetelescope:main Jul 9, 2024
29 of 30 checks passed
@schlafly schlafly deleted the fix-wcs branch July 9, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants