Fix issue in constructing skycell WCS. #1297
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some issues in the of the skycell WCS.
Formerly, the code used the center pixel of the WCS to mark the edge of the bounding box. That meant that the bounding box only covered a quarter of the image, leading to issues.
The "shift" used to move from the projection center was also using the edge of the bounding box. We now use the projection center in x/y coordinates.
This is intended to address an issue that @snbianco raised. I've placed a new example L3 image at
/grp/roman/eschlafly/misc/r0099101001001001001_F158_visit_r274dp63x31y81_i2d.asdf
that should have this issue fixed, but please check!