Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove pytest asdf plugin configuration for non-existant schemas #1305

Merged
merged 2 commits into from
Jul 18, 2024

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Jul 16, 2024

The pyproject.toml file contains configuration for the pytest asdf plugin (for testing schemas):

romancal/pyproject.toml

Lines 135 to 137 in 459e8e3

asdf_schema_tests_enabled = true
asdf_schema_validate_default = false
asdf_schema_root = "romancal/datamodels/schemas"

However there is no romancal/datamodels/schemas (the schemas exist and are tested in rad).

This PR removes the unnecessary configuration.

With this PR pytest finds 854 test items:
https://github.com/spacetelescope/romancal/actions/runs/9958232059/job/27512161042?pr=1305#step:10:154
the same number is found on main:
https://github.com/spacetelescope/romancal/actions/runs/9893953303/job/27330394884#step:10:154
verifying that no schemas are found for testing and that the configuration removed in this PR was doing nothing (but was adding an implicit dependency on the asdf pytest plugin).

Checklist

  • added entry in CHANGES.rst under the corresponding subsection
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below. How to run regression tests on a PR

@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Jul 16, 2024
@braingram braingram marked this pull request as ready for review July 16, 2024 13:59
@braingram braingram requested a review from a team as a code owner July 16, 2024 13:59
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.37%. Comparing base (7f4bc19) to head (05bfe45).
Report is 251 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1305   +/-   ##
=======================================
  Coverage   79.37%   79.37%           
=======================================
  Files         117      117           
  Lines        8086     8086           
=======================================
  Hits         6418     6418           
  Misses       1668     1668           
Flag Coverage Δ *Carryforward flag
nightly 62.86% <ø> (ø) Carriedforward from 4ae77c7

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@schlafly schlafly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@braingram
Copy link
Collaborator Author

Closing and re-opening to re-trigger the CI now that I wiped the webbpsf cache.

@braingram braingram closed this Jul 17, 2024
@braingram braingram reopened this Jul 17, 2024
@braingram braingram enabled auto-merge July 17, 2024 22:21
@braingram braingram disabled auto-merge July 17, 2024 22:37
@braingram
Copy link
Collaborator Author

@schlafly I'm not sure if closing and re-opening (to fix the bad webbpsf cache) dismissed your approval. Was this previously approved? If so, would you re-approve it?

@schlafly schlafly merged commit af07aa2 into spacetelescope:main Jul 18, 2024
47 of 53 checks passed
@braingram braingram deleted the cleanup_config branch July 18, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file no-changelog-entry-needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants